Skip to content

Commit b9eb3b1

Browse files
Dan Carpentermartinkpetersen
authored andcommitted
scsi: aacraid: fix a signedness bug
The problem is that ->reset_state is a u8 but it can be set to -1 or -2 in aac_tmf_callback() and the error handling in aac_eh_target_reset() relies on it to be signed. [mkp: fixed typo] Fixes: 0d643ff ("scsi: aacraid: use aac_tmf_callback for reset fib") Signed-off-by: Dan Carpenter <[email protected]> Signed-off-by: Martin K. Petersen <[email protected]>
1 parent d772a65 commit b9eb3b1

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/scsi/aacraid/aacraid.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1346,7 +1346,7 @@ struct fib {
13461346
struct aac_hba_map_info {
13471347
__le32 rmw_nexus; /* nexus for native HBA devices */
13481348
u8 devtype; /* device type */
1349-
u8 reset_state; /* 0 - no reset, 1..x - */
1349+
s8 reset_state; /* 0 - no reset, 1..x - */
13501350
/* after xth TM LUN reset */
13511351
u16 qd_limit;
13521352
u32 scan_counter;

0 commit comments

Comments
 (0)