Skip to content

Commit ba8afe9

Browse files
GustavoARSilvabroonie
authored andcommitted
spi/bcm63xx: fix error return code in bcm63xx_spi_probe()
platform_get_irq() returns an error code, but the spi-bcm63xx driver ignores it and always returns -ENXIO. This is not correct and, prevents -EPROBE_DEFER from being propagated properly. Notice that platform_get_irq() no longer returns 0 on error: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af Print and propagate the return value of platform_get_irq on failure. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva <[email protected]> Signed-off-by: Mark Brown <[email protected]>
1 parent 5771a8c commit ba8afe9

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/spi/spi-bcm63xx.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -530,8 +530,8 @@ static int bcm63xx_spi_probe(struct platform_device *pdev)
530530

531531
irq = platform_get_irq(pdev, 0);
532532
if (irq < 0) {
533-
dev_err(dev, "no irq\n");
534-
return -ENXIO;
533+
dev_err(dev, "no irq: %d\n", irq);
534+
return irq;
535535
}
536536

537537
clk = devm_clk_get(dev, "spi");

0 commit comments

Comments
 (0)