Skip to content

Commit ba9d114

Browse files
committed
libceph: clear r_req_lru_item in __unregister_linger_request()
kick_requests() can put linger requests on the notarget list. This means we need to clear the much-overloaded req->r_req_lru_item in __unregister_linger_request() as well, or we get an assertion failure in ceph_osdc_release_request() - !list_empty(&req->r_req_lru_item). AFAICT the assumption was that registered linger requests cannot be on any of req->r_req_lru_item lists, but that's clearly not the case. Signed-off-by: Ilya Dryomov <[email protected]> Reviewed-by: Alex Elder <[email protected]>
1 parent a390de0 commit ba9d114

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

net/ceph/osd_client.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1254,6 +1254,8 @@ static void __unregister_linger_request(struct ceph_osd_client *osdc,
12541254
if (list_empty(&req->r_osd_item))
12551255
req->r_osd = NULL;
12561256
}
1257+
1258+
list_del_init(&req->r_req_lru_item); /* can be on notarget */
12571259
ceph_osdc_put_request(req);
12581260
}
12591261

0 commit comments

Comments
 (0)