Skip to content

Commit bbe339c

Browse files
committed
btrfs: drop extra enum initialization where using defaults
The first auto-assigned value to enum is 0, we can use that and not initialize all members where the auto-increment does the same. This is used for values that are not part of on-disk format. Reviewed-by: Omar Sandoval <[email protected]> Reviewed-by: Qu Wenruo <[email protected]> Reviewed-by: Johannes Thumshirn <[email protected]> Signed-off-by: David Sterba <[email protected]>
1 parent 5b84030 commit bbe339c

File tree

6 files changed

+29
-29
lines changed

6 files changed

+29
-29
lines changed

fs/btrfs/btrfs_inode.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
* new data the application may have written before commit.
2121
*/
2222
enum {
23-
BTRFS_INODE_ORDERED_DATA_CLOSE = 0,
23+
BTRFS_INODE_ORDERED_DATA_CLOSE,
2424
BTRFS_INODE_DUMMY,
2525
BTRFS_INODE_IN_DEFRAG,
2626
BTRFS_INODE_HAS_ASYNC_EXTENT,

fs/btrfs/ctree.h

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -334,7 +334,7 @@ struct btrfs_node {
334334
* The slots array records the index of the item or block pointer
335335
* used while walking the tree.
336336
*/
337-
enum { READA_NONE = 0, READA_BACK, READA_FORWARD };
337+
enum { READA_NONE, READA_BACK, READA_FORWARD };
338338
struct btrfs_path {
339339
struct extent_buffer *nodes[BTRFS_MAX_LEVEL];
340340
int slots[BTRFS_MAX_LEVEL];
@@ -532,18 +532,18 @@ struct btrfs_free_cluster {
532532
};
533533

534534
enum btrfs_caching_type {
535-
BTRFS_CACHE_NO = 0,
536-
BTRFS_CACHE_STARTED = 1,
537-
BTRFS_CACHE_FAST = 2,
538-
BTRFS_CACHE_FINISHED = 3,
539-
BTRFS_CACHE_ERROR = 4,
535+
BTRFS_CACHE_NO,
536+
BTRFS_CACHE_STARTED,
537+
BTRFS_CACHE_FAST,
538+
BTRFS_CACHE_FINISHED,
539+
BTRFS_CACHE_ERROR,
540540
};
541541

542542
enum btrfs_disk_cache_state {
543-
BTRFS_DC_WRITTEN = 0,
544-
BTRFS_DC_ERROR = 1,
545-
BTRFS_DC_CLEAR = 2,
546-
BTRFS_DC_SETUP = 3,
543+
BTRFS_DC_WRITTEN,
544+
BTRFS_DC_ERROR,
545+
BTRFS_DC_CLEAR,
546+
BTRFS_DC_SETUP,
547547
};
548548

549549
struct btrfs_caching_control {
@@ -2621,10 +2621,10 @@ static inline gfp_t btrfs_alloc_write_mask(struct address_space *mapping)
26212621
/* extent-tree.c */
26222622

26232623
enum btrfs_inline_ref_type {
2624-
BTRFS_REF_TYPE_INVALID = 0,
2625-
BTRFS_REF_TYPE_BLOCK = 1,
2626-
BTRFS_REF_TYPE_DATA = 2,
2627-
BTRFS_REF_TYPE_ANY = 3,
2624+
BTRFS_REF_TYPE_INVALID,
2625+
BTRFS_REF_TYPE_BLOCK,
2626+
BTRFS_REF_TYPE_DATA,
2627+
BTRFS_REF_TYPE_ANY,
26282628
};
26292629

26302630
int btrfs_get_extent_inline_ref_type(const struct extent_buffer *eb,

fs/btrfs/disk-io.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,11 @@
2121
#define BTRFS_BDEV_BLOCKSIZE (4096)
2222

2323
enum btrfs_wq_endio_type {
24-
BTRFS_WQ_ENDIO_DATA = 0,
25-
BTRFS_WQ_ENDIO_METADATA = 1,
26-
BTRFS_WQ_ENDIO_FREE_SPACE = 2,
27-
BTRFS_WQ_ENDIO_RAID56 = 3,
28-
BTRFS_WQ_ENDIO_DIO_REPAIR = 4,
24+
BTRFS_WQ_ENDIO_DATA,
25+
BTRFS_WQ_ENDIO_METADATA,
26+
BTRFS_WQ_ENDIO_FREE_SPACE,
27+
BTRFS_WQ_ENDIO_RAID56,
28+
BTRFS_WQ_ENDIO_DIO_REPAIR,
2929
};
3030

3131
static inline u64 btrfs_sb_offset(int mirror)

fs/btrfs/qgroup.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ struct btrfs_qgroup_extent_record {
7070
* be converted into META_PERTRANS.
7171
*/
7272
enum btrfs_qgroup_rsv_type {
73-
BTRFS_QGROUP_RSV_DATA = 0,
73+
BTRFS_QGROUP_RSV_DATA,
7474
BTRFS_QGROUP_RSV_META_PERTRANS,
7575
BTRFS_QGROUP_RSV_META_PREALLOC,
7676
BTRFS_QGROUP_RSV_LAST,

fs/btrfs/sysfs.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
extern u64 btrfs_debugfs_test;
1010

1111
enum btrfs_feature_set {
12-
FEAT_COMPAT = 0,
12+
FEAT_COMPAT,
1313
FEAT_COMPAT_RO,
1414
FEAT_INCOMPAT,
1515
FEAT_MAX

fs/btrfs/transaction.h

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,13 @@
1212
#include "ctree.h"
1313

1414
enum btrfs_trans_state {
15-
TRANS_STATE_RUNNING = 0,
16-
TRANS_STATE_BLOCKED = 1,
17-
TRANS_STATE_COMMIT_START = 2,
18-
TRANS_STATE_COMMIT_DOING = 3,
19-
TRANS_STATE_UNBLOCKED = 4,
20-
TRANS_STATE_COMPLETED = 5,
21-
TRANS_STATE_MAX = 6,
15+
TRANS_STATE_RUNNING,
16+
TRANS_STATE_BLOCKED,
17+
TRANS_STATE_COMMIT_START,
18+
TRANS_STATE_COMMIT_DOING,
19+
TRANS_STATE_UNBLOCKED,
20+
TRANS_STATE_COMPLETED,
21+
TRANS_STATE_MAX,
2222
};
2323

2424
#define BTRFS_TRANS_HAVE_FREE_BGS 0

0 commit comments

Comments
 (0)