Skip to content

Commit bc0c335

Browse files
mjguzikakpm00
authored andcommitted
mm: remove remnants of SPLIT_RSS_COUNTING
The feature got retired in f1a7941 ("mm: convert mm's rss stats into percpu_counter"), but the patch failed to fully clean it up. Link: https://lkml.kernel.org/r/[email protected] Signed-off-by: Mateusz Guzik <[email protected]> Acked-by: Shakeel Butt <[email protected]> Signed-off-by: Andrew Morton <[email protected]>
1 parent 97144ce commit bc0c335

File tree

7 files changed

+1
-25
lines changed

7 files changed

+1
-25
lines changed

fs/exec.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -986,8 +986,6 @@ static int exec_mmap(struct mm_struct *mm)
986986
tsk = current;
987987
old_mm = current->mm;
988988
exec_mm_release(tsk, old_mm);
989-
if (old_mm)
990-
sync_mm_rss(old_mm);
991989

992990
ret = down_write_killable(&tsk->signal->exec_update_lock);
993991
if (ret)

include/linux/mm.h

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2628,14 +2628,6 @@ static inline void setmax_mm_hiwater_rss(unsigned long *maxrss,
26282628
*maxrss = hiwater_rss;
26292629
}
26302630

2631-
#if defined(SPLIT_RSS_COUNTING)
2632-
void sync_mm_rss(struct mm_struct *mm);
2633-
#else
2634-
static inline void sync_mm_rss(struct mm_struct *mm)
2635-
{
2636-
}
2637-
#endif
2638-
26392631
#ifndef CONFIG_ARCH_HAS_PTE_SPECIAL
26402632
static inline int pte_special(pte_t pte)
26412633
{

kernel/exit.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -539,7 +539,6 @@ static void exit_mm(void)
539539
exit_mm_release(current, mm);
540540
if (!mm)
541541
return;
542-
sync_mm_rss(mm);
543542
mmap_read_lock(mm);
544543
mmgrab_lazy_tlb(mm);
545544
BUG_ON(mm != current->active_mm);
@@ -829,9 +828,6 @@ void __noreturn do_exit(long code)
829828
io_uring_files_cancel();
830829
exit_signals(tsk); /* sets PF_EXITING */
831830

832-
/* sync mm's RSS info before statistics gathering */
833-
if (tsk->mm)
834-
sync_mm_rss(tsk->mm);
835831
acct_update_integrals(tsk);
836832
group_dead = atomic_dec_and_test(&tsk->signal->live);
837833
if (group_dead) {

kernel/fork.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2406,10 +2406,6 @@ __latent_entropy struct task_struct *copy_process(
24062406
p->io_uring = NULL;
24072407
#endif
24082408

2409-
#if defined(SPLIT_RSS_COUNTING)
2410-
memset(&p->rss_stat, 0, sizeof(p->rss_stat));
2411-
#endif
2412-
24132409
p->default_timer_slack_ns = current->timer_slack_ns;
24142410

24152411
#ifdef CONFIG_PSI

kernel/kthread.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1469,7 +1469,6 @@ void kthread_unuse_mm(struct mm_struct *mm)
14691469
* clearing tsk->mm.
14701470
*/
14711471
smp_mb__after_spinlock();
1472-
sync_mm_rss(mm);
14731472
local_irq_disable();
14741473
tsk->mm = NULL;
14751474
membarrier_update_current_mm(NULL);

mm/madvise.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -746,11 +746,8 @@ static int madvise_free_pte_range(pmd_t *pmd, unsigned long addr,
746746
folio_mark_lazyfree(folio);
747747
}
748748

749-
if (nr_swap) {
750-
if (current->mm == mm)
751-
sync_mm_rss(mm);
749+
if (nr_swap)
752750
add_mm_counter(mm, MM_SWAPENTS, nr_swap);
753-
}
754751
if (start_pte) {
755752
arch_leave_lazy_mmu_mode();
756753
pte_unmap_unlock(start_pte, ptl);

mm/memory.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -471,8 +471,6 @@ static inline void add_mm_rss_vec(struct mm_struct *mm, int *rss)
471471
{
472472
int i;
473473

474-
if (current->mm == mm)
475-
sync_mm_rss(mm);
476474
for (i = 0; i < NR_MM_COUNTERS; i++)
477475
if (rss[i])
478476
add_mm_counter(mm, i, rss[i]);

0 commit comments

Comments
 (0)