Skip to content

Commit bc9e9cf

Browse files
Mikulas Patockasnitm
authored andcommitted
dm crypt: don't decrease device limits
dm-crypt should only increase device limits, it should not decrease them. This fixes a bug where the user could creates a crypt device with 1024 sector size on the top of scsi device that had 4096 logical block size. The limit 4096 would be lost and the user could incorrectly send 1024-I/Os to the crypt device. Cc: [email protected] Signed-off-by: Mikulas Patocka <[email protected]> Signed-off-by: Mike Snitzer <[email protected]>
1 parent 5b1fe7b commit bc9e9cf

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

drivers/md/dm-crypt.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3061,11 +3061,11 @@ static void crypt_io_hints(struct dm_target *ti, struct queue_limits *limits)
30613061
*/
30623062
limits->max_segment_size = PAGE_SIZE;
30633063

3064-
if (cc->sector_size != (1 << SECTOR_SHIFT)) {
3065-
limits->logical_block_size = cc->sector_size;
3066-
limits->physical_block_size = cc->sector_size;
3067-
blk_limits_io_min(limits, cc->sector_size);
3068-
}
3064+
limits->logical_block_size =
3065+
max_t(unsigned short, limits->logical_block_size, cc->sector_size);
3066+
limits->physical_block_size =
3067+
max_t(unsigned, limits->physical_block_size, cc->sector_size);
3068+
limits->io_min = max_t(unsigned, limits->io_min, cc->sector_size);
30693069
}
30703070

30713071
static struct target_type crypt_target = {

0 commit comments

Comments
 (0)