Skip to content

Commit bcc728e

Browse files
Chengming Zhouakpm00
authored andcommitted
mm/damon: remove obsolete comments of kdamond_stop
Since commit 0f91d13 ("mm/damon: simplify stop mechanism") delete kdamond_stop and change to use kthread stop mechanism, these obsolete comments should be removed accordingly. Link: https://lkml.kernel.org/r/[email protected] Signed-off-by: Chengming Zhou <[email protected]> Reviewed-by: SeongJae Park <[email protected]> Signed-off-by: Andrew Morton <[email protected]>
1 parent 943189d commit bcc728e

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

include/linux/damon.h

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -397,7 +397,6 @@ struct damon_callback {
397397
* detail.
398398
*
399399
* @kdamond: Kernel thread who does the monitoring.
400-
* @kdamond_stop: Notifies whether kdamond should stop.
401400
* @kdamond_lock: Mutex for the synchronizations with @kdamond.
402401
*
403402
* For each monitoring context, one kernel thread for the monitoring is
@@ -406,14 +405,14 @@ struct damon_callback {
406405
* Once started, the monitoring thread runs until explicitly required to be
407406
* terminated or every monitoring target is invalid. The validity of the
408407
* targets is checked via the &damon_operations.target_valid of @ops. The
409-
* termination can also be explicitly requested by writing non-zero to
410-
* @kdamond_stop. The thread sets @kdamond to NULL when it terminates.
411-
* Therefore, users can know whether the monitoring is ongoing or terminated by
412-
* reading @kdamond. Reads and writes to @kdamond and @kdamond_stop from
413-
* outside of the monitoring thread must be protected by @kdamond_lock.
414-
*
415-
* Note that the monitoring thread protects only @kdamond and @kdamond_stop via
416-
* @kdamond_lock. Accesses to other fields must be protected by themselves.
408+
* termination can also be explicitly requested by calling damon_stop().
409+
* The thread sets @kdamond to NULL when it terminates. Therefore, users can
410+
* know whether the monitoring is ongoing or terminated by reading @kdamond.
411+
* Reads and writes to @kdamond from outside of the monitoring thread must
412+
* be protected by @kdamond_lock.
413+
*
414+
* Note that the monitoring thread protects only @kdamond via @kdamond_lock.
415+
* Accesses to other fields must be protected by themselves.
417416
*
418417
* @ops: Set of monitoring operations for given use cases.
419418
* @callback: Set of callbacks for monitoring events notifications.

0 commit comments

Comments
 (0)