ipv6: ignore looped-back NA while dad is running

sahne · davem330 · commit bd015928bb17 · 2011-04-15T15:43:55.000-07:00
[ipv6] Ignore looped-back NAs while in Duplicate Address Detection

If we send an unsolicited NA shortly after bringing up an
IPv6 address, the duplicate address detection algorithm
fails and the ip stays in tentative mode forever.
This is due a missing check if the NA is looped-back to us.

Signed-off-by: Daniel Walter &lt;dwalter@barracuda.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c
@@ -945,9 +945,10 @@ static void ndisc_recv_na(struct sk_buff *skb)
 	}
 	ifp = ipv6_get_ifaddr(dev_net(dev), &msg->target, dev, 1);
 	if (ifp) {
-		if (ifp->flags & IFA_F_TENTATIVE) {
-			addrconf_dad_failure(ifp);
-			return;
+		if (skb->pkt_type != PACKET_LOOPBACK
+		    && (ifp->flags & IFA_F_TENTATIVE)) {
+				addrconf_dad_failure(ifp);
+				return;
 		}
 		/* What should we make now? The advertisement
 		   is invalid, but ndisc specs say nothing

Original file line number	Diff line number	Diff line change
`@@ -945,9 +945,10 @@ static void ndisc_recv_na(struct sk_buff *skb)`
`945`	`945`	`}`
`946`	`946`	`ifp = ipv6_get_ifaddr(dev_net(dev), &msg->target, dev, 1);`
`947`	`947`	`if (ifp) {`
`948`		`- if (ifp->flags & IFA_F_TENTATIVE) {`
`949`		`- addrconf_dad_failure(ifp);`
`950`		`- return;`
	`948`	`+ if (skb->pkt_type != PACKET_LOOPBACK`
	`949`	`+ && (ifp->flags & IFA_F_TENTATIVE)) {`
	`950`	`+ addrconf_dad_failure(ifp);`
	`951`	`+ return;`
`951`	`952`	`}`
`952`	`953`	`/* What should we make now? The advertisement`
`953`	`954`	`is invalid, but ndisc specs say nothing`