tipc: fix a missing rhashtable_walk_exit()

congwang · davem330 · commit bd583fe30427 · 2018-08-29T17:52:58.000-07:00
rhashtable_walk_exit() must be paired with rhashtable_walk_enter(). Fixes: 40f9f43 ("tipc: Fix tipc_sk_reinit race conditions") Cc: Herbert Xu <herbert@gondor.apana.org.au> Cc: Ying Xue <ying.xue@windriver.com> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/net/tipc/socket.c b/net/tipc/socket.c
@@ -2672,6 +2672,8 @@ void tipc_sk_reinit(struct net *net)
 
 		rhashtable_walk_stop(&iter);
 	} while (tsk == ERR_PTR(-EAGAIN));
+
+	rhashtable_walk_exit(&iter);
 }
 
 static struct tipc_sock *tipc_sk_lookup(struct net *net, u32 portid)

Original file line number	Diff line number	Diff line change
`@@ -2672,6 +2672,8 @@ void tipc_sk_reinit(struct net *net)`
`2672`	`2672`
`2673`	`2673`	`rhashtable_walk_stop(&iter);`
`2674`	`2674`	`} while (tsk == ERR_PTR(-EAGAIN));`
	`2675`	`+`
	`2676`	`+ rhashtable_walk_exit(&iter);`
`2675`	`2677`	`}`
`2676`	`2678`
`2677`	`2679`	`static struct tipc_sock tipc_sk_lookup(struct net net, u32 portid)`