Skip to content

Commit bdafe42

Browse files
committed
ext4: fix spelling errors and a comment in extent_status tree
Replace "assertation" with "assertion" in lots and lots of debugging messages. Correct the comment stating when ext4_es_insert_extent() is used. It was no doubt tree at one point, but it is no longer true... Signed-off-by: "Theodore Ts'o" <[email protected]> Cc: Zheng Liu <[email protected]>
1 parent e8974c3 commit bdafe42

File tree

2 files changed

+14
-16
lines changed

2 files changed

+14
-16
lines changed

fs/ext4/extents_status.c

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -439,7 +439,7 @@ static void ext4_es_insert_extent_ext_check(struct inode *inode,
439439
*/
440440
if (!ext4_es_is_written(es) && !ext4_es_is_unwritten(es)) {
441441
if (in_range(es->es_lblk, ee_block, ee_len)) {
442-
pr_warn("ES insert assertation failed for "
442+
pr_warn("ES insert assertion failed for "
443443
"inode: %lu we can find an extent "
444444
"at block [%d/%d/%llu/%c], but we "
445445
"want to add an delayed/hole extent "
@@ -458,7 +458,7 @@ static void ext4_es_insert_extent_ext_check(struct inode *inode,
458458
*/
459459
if (es->es_lblk < ee_block ||
460460
ext4_es_pblock(es) != ee_start + es->es_lblk - ee_block) {
461-
pr_warn("ES insert assertation failed for inode: %lu "
461+
pr_warn("ES insert assertion failed for inode: %lu "
462462
"ex_status [%d/%d/%llu/%c] != "
463463
"es_status [%d/%d/%llu/%c]\n", inode->i_ino,
464464
ee_block, ee_len, ee_start,
@@ -468,7 +468,7 @@ static void ext4_es_insert_extent_ext_check(struct inode *inode,
468468
}
469469

470470
if (ee_status ^ es_status) {
471-
pr_warn("ES insert assertation failed for inode: %lu "
471+
pr_warn("ES insert assertion failed for inode: %lu "
472472
"ex_status [%d/%d/%llu/%c] != "
473473
"es_status [%d/%d/%llu/%c]\n", inode->i_ino,
474474
ee_block, ee_len, ee_start,
@@ -481,7 +481,7 @@ static void ext4_es_insert_extent_ext_check(struct inode *inode,
481481
* that we don't want to add an written/unwritten extent.
482482
*/
483483
if (!ext4_es_is_delayed(es) && !ext4_es_is_hole(es)) {
484-
pr_warn("ES insert assertation failed for inode: %lu "
484+
pr_warn("ES insert assertion failed for inode: %lu "
485485
"can't find an extent at block %d but we want "
486486
"to add an written/unwritten extent "
487487
"[%d/%d/%llu/%llx]\n", inode->i_ino,
@@ -519,21 +519,21 @@ static void ext4_es_insert_extent_ind_check(struct inode *inode,
519519
* We want to add a delayed/hole extent but this
520520
* block has been allocated.
521521
*/
522-
pr_warn("ES insert assertation failed for inode: %lu "
522+
pr_warn("ES insert assertion failed for inode: %lu "
523523
"We can find blocks but we want to add a "
524524
"delayed/hole extent [%d/%d/%llu/%llx]\n",
525525
inode->i_ino, es->es_lblk, es->es_len,
526526
ext4_es_pblock(es), ext4_es_status(es));
527527
return;
528528
} else if (ext4_es_is_written(es)) {
529529
if (retval != es->es_len) {
530-
pr_warn("ES insert assertation failed for "
530+
pr_warn("ES insert assertion failed for "
531531
"inode: %lu retval %d != es_len %d\n",
532532
inode->i_ino, retval, es->es_len);
533533
return;
534534
}
535535
if (map.m_pblk != ext4_es_pblock(es)) {
536-
pr_warn("ES insert assertation failed for "
536+
pr_warn("ES insert assertion failed for "
537537
"inode: %lu m_pblk %llu != "
538538
"es_pblk %llu\n",
539539
inode->i_ino, map.m_pblk,
@@ -549,7 +549,7 @@ static void ext4_es_insert_extent_ind_check(struct inode *inode,
549549
}
550550
} else if (retval == 0) {
551551
if (ext4_es_is_written(es)) {
552-
pr_warn("ES insert assertation failed for inode: %lu "
552+
pr_warn("ES insert assertion failed for inode: %lu "
553553
"We can't find the block but we want to add "
554554
"an written extent [%d/%d/%llu/%llx]\n",
555555
inode->i_ino, es->es_lblk, es->es_len,
@@ -632,10 +632,8 @@ static int __es_insert_extent(struct inode *inode, struct extent_status *newes)
632632
}
633633

634634
/*
635-
* ext4_es_insert_extent() adds a space to a extent status tree.
636-
*
637-
* ext4_es_insert_extent is called by ext4_da_write_begin and
638-
* ext4_es_remove_extent.
635+
* ext4_es_insert_extent() adds information to an inode's extent
636+
* status tree.
639637
*
640638
* Return 0 on success, error code on failure.
641639
*/

fs/ext4/inode.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -465,7 +465,7 @@ static void ext4_map_blocks_es_recheck(handle_t *handle,
465465
if (es_map->m_lblk != map->m_lblk ||
466466
es_map->m_flags != map->m_flags ||
467467
es_map->m_pblk != map->m_pblk) {
468-
printk("ES cache assertation failed for inode: %lu "
468+
printk("ES cache assertion failed for inode: %lu "
469469
"es_cached ex [%d/%d/%llu/%x] != "
470470
"found ex [%d/%d/%llu/%x] retval %d flags %x\n",
471471
inode->i_ino, es_map->m_lblk, es_map->m_len,
@@ -558,7 +558,7 @@ int ext4_map_blocks(handle_t *handle, struct inode *inode,
558558

559559
#ifdef ES_AGGRESSIVE_TEST
560560
if (retval != map->m_len) {
561-
printk("ES len assertation failed for inode: %lu "
561+
printk("ES len assertion failed for inode: %lu "
562562
"retval %d != map->m_len %d "
563563
"in %s (lookup)\n", inode->i_ino, retval,
564564
map->m_len, __func__);
@@ -659,7 +659,7 @@ int ext4_map_blocks(handle_t *handle, struct inode *inode,
659659

660660
#ifdef ES_AGGRESSIVE_TEST
661661
if (retval != map->m_len) {
662-
printk("ES len assertation failed for inode: %lu "
662+
printk("ES len assertion failed for inode: %lu "
663663
"retval %d != map->m_len %d "
664664
"in %s (allocation)\n", inode->i_ino, retval,
665665
map->m_len, __func__);
@@ -1642,7 +1642,7 @@ static int ext4_da_map_blocks(struct inode *inode, sector_t iblock,
16421642

16431643
#ifdef ES_AGGRESSIVE_TEST
16441644
if (retval != map->m_len) {
1645-
printk("ES len assertation failed for inode: %lu "
1645+
printk("ES len assertion failed for inode: %lu "
16461646
"retval %d != map->m_len %d "
16471647
"in %s (lookup)\n", inode->i_ino, retval,
16481648
map->m_len, __func__);

0 commit comments

Comments
 (0)