Skip to content

Commit be4e323

Browse files
Amit Cohenkuba-moo
authored andcommitted
selftests: mlxsw: rtnetlink: Use devlink_reload() API
The test runs "devlink reload" explicitly. Instead, it is better to use devlink_reload() which waits for udev events to be processed. Do not sleep after reload, as devlink_reload() blocks until all the netdevs are renamed. Signed-off-by: Amit Cohen <[email protected]> Reviewed-by: Ido Schimmel <[email protected]> Signed-off-by: Petr Machata <[email protected]> Link: https://patch.msgid.link/844509e3057b65277a7181a23c95b71ec95e8a56.1727706741.git.petrm@nvidia.com Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 25ba2a5 commit be4e323

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

tools/testing/selftests/drivers/net/mlxsw/rtnetlink.sh

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -186,10 +186,7 @@ bridge_vlan_flags_test()
186186

187187
# If we did not handle references correctly, then this should produce a
188188
# trace
189-
devlink dev reload "$DEVLINK_DEV"
190-
191-
# Allow netdevices to be re-created following the reload
192-
sleep 20
189+
devlink_reload
193190

194191
log_test "bridge vlan flags"
195192
}
@@ -923,12 +920,9 @@ devlink_reload_test()
923920
# devlink reload can be performed without errors
924921
RET=0
925922

926-
devlink dev reload "$DEVLINK_DEV"
927-
check_err $? "devlink reload failed"
923+
devlink_reload
928924

929925
log_test "devlink reload - last test"
930-
931-
sleep 20
932926
}
933927

934928
trap cleanup EXIT

0 commit comments

Comments
 (0)