Skip to content

Commit bed90b0

Browse files
robimarkoPaolo Abeni
authored andcommitted
net: phy: aquantia: clear PMD Global Transmit Disable bit during init
PMD Global Transmit Disable bit should be cleared for normal operation. This should be HW default, however I found that on Asus RT-AX89X that uses AQR113C PHY and firmware 5.4 this bit is set by default. With this bit set the AQR cannot achieve a link with its link-partner and it took me multiple hours of digging through the vendor GPL source to find this out, so lets always clear this bit during .config_init() to avoid a situation like this in the future. Signed-off-by: Robert Marko <[email protected]> Reviewed-by: Andrew Lunn <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Paolo Abeni <[email protected]>
1 parent 32c7eec commit bed90b0

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

drivers/net/phy/aquantia/aquantia_main.c

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -727,6 +727,15 @@ static int aqr113c_config_init(struct phy_device *phydev)
727727
if (ret < 0)
728728
return ret;
729729

730+
ret = phy_clear_bits_mmd(phydev, MDIO_MMD_PMAPMD, MDIO_PMA_TXDIS,
731+
MDIO_PMD_TXDIS_GLOBAL);
732+
if (ret)
733+
return ret;
734+
735+
ret = aqr107_wait_processor_intensive_op(phydev);
736+
if (ret)
737+
return ret;
738+
730739
return aqr107_fill_interface_modes(phydev);
731740
}
732741

0 commit comments

Comments
 (0)