Skip to content

Commit bf1cafa

Browse files
JuliaLawallLee Jones
authored andcommitted
mfd: kempld-core: Constify variables that point to const structure
Add const to the declaration of various local variables of type kempld_platform_data for which the referenced value is always only dereferenced or passed to a const parameter, to record the fact that kempld_platform_data_generic is declared as const. The semantic match that finds this issue is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r@ identifier i,j; @@ const struct i j = { ... }; @ok@ identifier r.i; position p; @@ const struct i@p * @@ identifier r.i; position p != ok.p; @@ * struct i@p * // </smpl> Signed-off-by: Julia Lawall <[email protected]> Signed-off-by: Lee Jones <[email protected]>
1 parent e5ff19c commit bf1cafa

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

drivers/mfd/kempld-core.c

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ static struct platform_device *kempld_pdev;
143143

144144
static int kempld_create_platform_device(const struct dmi_system_id *id)
145145
{
146-
struct kempld_platform_data *pdata = id->driver_data;
146+
const struct kempld_platform_data *pdata = id->driver_data;
147147
int ret;
148148

149149
kempld_pdev = platform_device_alloc("kempld", -1);
@@ -259,7 +259,7 @@ EXPORT_SYMBOL_GPL(kempld_write32);
259259
*/
260260
void kempld_get_mutex(struct kempld_device_data *pld)
261261
{
262-
struct kempld_platform_data *pdata = dev_get_platdata(pld->dev);
262+
const struct kempld_platform_data *pdata = dev_get_platdata(pld->dev);
263263

264264
mutex_lock(&pld->lock);
265265
pdata->get_hardware_mutex(pld);
@@ -272,7 +272,7 @@ EXPORT_SYMBOL_GPL(kempld_get_mutex);
272272
*/
273273
void kempld_release_mutex(struct kempld_device_data *pld)
274274
{
275-
struct kempld_platform_data *pdata = dev_get_platdata(pld->dev);
275+
const struct kempld_platform_data *pdata = dev_get_platdata(pld->dev);
276276

277277
pdata->release_hardware_mutex(pld);
278278
mutex_unlock(&pld->lock);
@@ -290,7 +290,7 @@ EXPORT_SYMBOL_GPL(kempld_release_mutex);
290290
static int kempld_get_info(struct kempld_device_data *pld)
291291
{
292292
int ret;
293-
struct kempld_platform_data *pdata = dev_get_platdata(pld->dev);
293+
const struct kempld_platform_data *pdata = dev_get_platdata(pld->dev);
294294
char major, minor;
295295

296296
ret = pdata->get_info(pld);
@@ -332,7 +332,7 @@ static int kempld_get_info(struct kempld_device_data *pld)
332332
*/
333333
static int kempld_register_cells(struct kempld_device_data *pld)
334334
{
335-
struct kempld_platform_data *pdata = dev_get_platdata(pld->dev);
335+
const struct kempld_platform_data *pdata = dev_get_platdata(pld->dev);
336336

337337
return pdata->register_cells(pld);
338338
}
@@ -444,7 +444,8 @@ static int kempld_detect_device(struct kempld_device_data *pld)
444444

445445
static int kempld_probe(struct platform_device *pdev)
446446
{
447-
struct kempld_platform_data *pdata = dev_get_platdata(&pdev->dev);
447+
const struct kempld_platform_data *pdata =
448+
dev_get_platdata(&pdev->dev);
448449
struct device *dev = &pdev->dev;
449450
struct kempld_device_data *pld;
450451
struct resource *ioport;
@@ -476,7 +477,7 @@ static int kempld_probe(struct platform_device *pdev)
476477
static int kempld_remove(struct platform_device *pdev)
477478
{
478479
struct kempld_device_data *pld = platform_get_drvdata(pdev);
479-
struct kempld_platform_data *pdata = dev_get_platdata(pld->dev);
480+
const struct kempld_platform_data *pdata = dev_get_platdata(pld->dev);
480481

481482
sysfs_remove_group(&pld->dev->kobj, &pld_attr_group);
482483

0 commit comments

Comments
 (0)