Skip to content

Commit bfa3837

Browse files
committed
fscache, cachefiles: Fix checker warnings
Fix a couple of checker warnings in fscache and cachefiles: (1) fscache_n_op_requeue is never used, so get rid of it. (2) cachefiles_uncache_page() is passed in a lock that it releases, so this needs annotating. Signed-off-by: David Howells <[email protected]>
1 parent 678edd0 commit bfa3837

File tree

2 files changed

+1
-1
lines changed

2 files changed

+1
-1
lines changed

fs/cachefiles/rdwr.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -952,6 +952,7 @@ int cachefiles_write_page(struct fscache_storage *op, struct page *page)
952952
* - cache withdrawal is prevented by the caller
953953
*/
954954
void cachefiles_uncache_page(struct fscache_object *_object, struct page *page)
955+
__releases(&object->fscache.cookie->lock)
955956
{
956957
struct cachefiles_object *object;
957958
struct cachefiles_cache *cache;

fs/fscache/stats.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
atomic_t fscache_n_op_pend;
2222
atomic_t fscache_n_op_run;
2323
atomic_t fscache_n_op_enqueue;
24-
atomic_t fscache_n_op_requeue;
2524
atomic_t fscache_n_op_deferred_release;
2625
atomic_t fscache_n_op_initialised;
2726
atomic_t fscache_n_op_release;

0 commit comments

Comments
 (0)