Skip to content

Commit bfbb234

Browse files
author
Gerrit Renker
committed
dccp: make upper bound for seq_window consistent on 32/64 bit
The 'seq_window' sysctl sets the initial value for the DCCP Sequence Window, which may range from 32..2^46-1 (RFC 4340, 7.5.2). The patch sets the upper bound consistently to 2^32-1 on both 32 and 64 bit systems, which should be sufficient - with a RTT of 1sec and 1-byte packets, a seq_window of 2^32-1 corresponds to a link speed of 34 Gbps. Signed-off-by: Gerrit Renker <[email protected]>
1 parent 763dadd commit bfbb234

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

Documentation/networking/dccp.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,7 @@ rx_ccid = 2
167167
seq_window = 100
168168
The initial sequence window (sec. 7.5.2) of the sender. This influences
169169
the local ackno validity and the remote seqno validity windows (7.5.1).
170+
Values in the range Wmin = 32 (RFC 4340, 7.5.2) up to 2^32-1 can be set.
170171

171172
tx_qlen = 5
172173
The size of the transmit buffer in packets. A value of 0 corresponds

net/dccp/sysctl.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@
2121
/* Boundary values */
2222
static int zero = 0,
2323
u8_max = 0xFF;
24-
static unsigned long seqw_min = 32;
24+
static unsigned long seqw_min = DCCPF_SEQ_WMIN,
25+
seqw_max = 0xFFFFFFFF; /* maximum on 32 bit */
2526

2627
static struct ctl_table dccp_default_table[] = {
2728
{
@@ -31,6 +32,7 @@ static struct ctl_table dccp_default_table[] = {
3132
.mode = 0644,
3233
.proc_handler = proc_doulongvec_minmax,
3334
.extra1 = &seqw_min, /* RFC 4340, 7.5.2 */
35+
.extra2 = &seqw_max,
3436
},
3537
{
3638
.procname = "rx_ccid",

0 commit comments

Comments
 (0)