Skip to content

Commit bfecbcb

Browse files
Jorge Lopezjwrdegoede
authored andcommitted
platform/x86: hp-bioscfg: Remove duplicate use of variable in inner loop
Replace use of same variable in inner loop. Signed-off-by: Jorge Lopez <[email protected]> Link: https://lore.kernel.org/r/[email protected] Reviewed-by: Hans de Goede <[email protected]> Signed-off-by: Hans de Goede <[email protected]>
1 parent efd4211 commit bfecbcb

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,7 @@ static int hp_populate_ordered_list_elements_from_package(union acpi_object *ord
136136
u32 size;
137137
u32 int_value = 0;
138138
int elem;
139+
int olist_elem;
139140
int reqs;
140141
int eloc;
141142
char *tmpstr = NULL;
@@ -147,10 +148,7 @@ static int hp_populate_ordered_list_elements_from_package(union acpi_object *ord
147148
if (!order_obj)
148149
return -EINVAL;
149150

150-
for (elem = 1, eloc = 1; elem < order_obj_count; elem++, eloc++) {
151-
/* ONLY look at the first ORDERED_ELEM_CNT elements */
152-
if (eloc == ORD_ELEM_CNT)
153-
goto exit_list;
151+
for (elem = 1, eloc = 1; eloc < ORD_ELEM_CNT; elem++, eloc++) {
154152

155153
switch (order_obj[elem].type) {
156154
case ACPI_TYPE_STRING:
@@ -277,10 +275,10 @@ static int hp_populate_ordered_list_elements_from_package(union acpi_object *ord
277275
tmpstr,
278276
sizeof(ordered_list_data->elements[0]));
279277

280-
for (elem = 1; elem < MAX_ELEMENTS_SIZE && part; elem++) {
281-
strscpy(ordered_list_data->elements[elem],
278+
for (olist_elem = 1; olist_elem < MAX_ELEMENTS_SIZE && part; olist_elem++) {
279+
strscpy(ordered_list_data->elements[olist_elem],
282280
part,
283-
sizeof(ordered_list_data->elements[elem]));
281+
sizeof(ordered_list_data->elements[olist_elem]));
284282
part = strsep(&part_tmp, SEMICOLON_SEP);
285283
}
286284

0 commit comments

Comments
 (0)