Skip to content

Commit c01513b

Browse files
Dan Carpentergregkh
authored andcommitted
eeprom: idt_89hpesx: clean up an error pointer vs NULL inconsistency
We check for IS_ERR_OR_NULL() here, but later we check the same thing for NULL only. It turns out that it can only be NULL so we can make the checking consistent by removing the ERR_PTR stuff. Signed-off-by: Dan Carpenter <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 81ae962 commit c01513b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/misc/eeprom/idt_89hpesx.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1128,7 +1128,7 @@ static void idt_get_fw_data(struct idt_89hpesx_dev *pdev)
11281128

11291129
device_for_each_child_node(dev, fwnode) {
11301130
ee_id = idt_ee_match_id(fwnode);
1131-
if (IS_ERR_OR_NULL(ee_id)) {
1131+
if (!ee_id) {
11321132
dev_warn(dev, "Skip unsupported EEPROM device");
11331133
continue;
11341134
} else

0 commit comments

Comments
 (0)