Skip to content

Commit c0561f8

Browse files
hreineckeChristoph Hellwig
authored andcommitted
nvme: submit AEN event configuration on startup
We should register for AEN events; some law-abiding targets might not be sending us AENs otherwise. Signed-off-by: Hannes Reinecke <[email protected]> [hch: slight cleanups] Signed-off-by: Christoph Hellwig <[email protected]> Reviewed-by: Johannes Thumshirn <[email protected]> Reviewed-by: Sagi Grimberg <[email protected]>
1 parent 55fdd6b commit c0561f8

File tree

2 files changed

+18
-0
lines changed

2 files changed

+18
-0
lines changed

drivers/nvme/host/core.c

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1030,6 +1030,21 @@ int nvme_set_queue_count(struct nvme_ctrl *ctrl, int *count)
10301030
}
10311031
EXPORT_SYMBOL_GPL(nvme_set_queue_count);
10321032

1033+
#define NVME_AEN_SUPPORTED \
1034+
(NVME_AEN_CFG_NS_ATTR | NVME_AEN_CFG_FW_ACT)
1035+
1036+
static void nvme_enable_aen(struct nvme_ctrl *ctrl)
1037+
{
1038+
u32 result;
1039+
int status;
1040+
1041+
status = nvme_set_features(ctrl, NVME_FEAT_ASYNC_EVENT,
1042+
ctrl->oaes & NVME_AEN_SUPPORTED, NULL, 0, &result);
1043+
if (status)
1044+
dev_warn(ctrl->device, "Failed to configure AEN (cfg %x)\n",
1045+
ctrl->oaes & NVME_AEN_SUPPORTED);
1046+
}
1047+
10331048
static int nvme_submit_io(struct nvme_ns *ns, struct nvme_user_io __user *uio)
10341049
{
10351050
struct nvme_user_io io;
@@ -2347,6 +2362,7 @@ int nvme_init_identify(struct nvme_ctrl *ctrl)
23472362

23482363
ctrl->oacs = le16_to_cpu(id->oacs);
23492364
ctrl->oncs = le16_to_cpup(&id->oncs);
2365+
ctrl->oaes = le32_to_cpu(id->oaes);
23502366
atomic_set(&ctrl->abort_limit, id->acl + 1);
23512367
ctrl->vwc = id->vwc;
23522368
ctrl->cntlid = le16_to_cpup(&id->cntlid);
@@ -3379,6 +3395,7 @@ void nvme_start_ctrl(struct nvme_ctrl *ctrl)
33793395

33803396
if (ctrl->queue_count > 1) {
33813397
nvme_queue_scan(ctrl);
3398+
nvme_enable_aen(ctrl);
33823399
queue_work(nvme_wq, &ctrl->async_event_work);
33833400
nvme_start_queues(ctrl);
33843401
}

drivers/nvme/host/nvme.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -176,6 +176,7 @@ struct nvme_ctrl {
176176
u16 kas;
177177
u8 npss;
178178
u8 apsta;
179+
u32 oaes;
179180
u32 aen_result;
180181
unsigned int shutdown_timeout;
181182
unsigned int kato;

0 commit comments

Comments
 (0)