Skip to content

Commit c0ae359

Browse files
larsclausenjic23
authored andcommitted
iio: dma-buffer: Cleanup buffer.h/buffer_impl.h includes
The IIO DMA buffer is a DMA buffer implementation. As such it should include buffer_impl.h rather than buffer.h. The include to buffer.h in buffer-dma.h should be buffer_impl.h so it has access to the struct iio_buffer definition. The code currently only works because all places that use buffer-dma.h include buffer_impl.h before it. The include to buffer.h in industrialio-buffer-dma.c can be removed since those file does not reference any of buffer consumer functions. Signed-off-by: Lars-Peter Clausen <[email protected]> Tested-by: Alexandru Ardelean <[email protected]> Signed-off-by: Jonathan Cameron <[email protected]>
1 parent 8a80a71 commit c0ae359

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

drivers/iio/buffer/industrialio-buffer-dma.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
#include <linux/mutex.h>
1313
#include <linux/sched.h>
1414
#include <linux/poll.h>
15-
#include <linux/iio/buffer.h>
1615
#include <linux/iio/buffer_impl.h>
1716
#include <linux/iio/buffer-dma.h>
1817
#include <linux/dma-mapping.h>

include/linux/iio/buffer-dma.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
#include <linux/kref.h>
1212
#include <linux/spinlock.h>
1313
#include <linux/mutex.h>
14-
#include <linux/iio/buffer.h>
14+
#include <linux/iio/buffer_impl.h>
1515

1616
struct iio_dma_buffer_queue;
1717
struct iio_dma_buffer_ops;

0 commit comments

Comments
 (0)