Skip to content

Commit c12fc45

Browse files
committed
rpmsg: smd: Create device for all channels
Rather than selectively creating devices only for the channels that the remote have moved to "opening" state let's create devices for all channels found. The driver model will match drivers to the ones we care about and attempt to open these. The one case where this fails is if the user loads a firmware that lacks a particular channel of the previous firmware that was running, in which case we would find the old channel and attempt to probe it. The channel opening handshake will ensure this will result in a graceful failure. The result of this patch is that we will actively open the RPM channel even though it's left in a state other than "opening" after the boot loader's closing of the channel. Tested-by: Will Newton <[email protected]> Reported-by: Jeremy McNicoll <[email protected]> Reported-by: Will Newton <[email protected]> Signed-off-by: Bjorn Andersson <[email protected]>
1 parent 268105f commit c12fc45

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

drivers/rpmsg/qcom_smd.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1225,11 +1225,6 @@ static void qcom_channel_state_worker(struct work_struct *work)
12251225
if (channel->state != SMD_CHANNEL_CLOSED)
12261226
continue;
12271227

1228-
remote_state = GET_RX_CHANNEL_INFO(channel, state);
1229-
if (remote_state != SMD_CHANNEL_OPENING &&
1230-
remote_state != SMD_CHANNEL_OPENED)
1231-
continue;
1232-
12331228
if (channel->registered)
12341229
continue;
12351230

0 commit comments

Comments
 (0)