Skip to content

Commit c141afd

Browse files
committed
Merge branch 'fixes' of git://git.armlinux.org.uk/~rmk/linux-arm
Pull ARM fixes from Russell King: "A couple of fixes for pmd_mknotpresent()/pmd_present() for LPAE systems" * 'fixes' of git://git.armlinux.org.uk/~rmk/linux-arm: ARM: 8579/1: mm: Fix definition of pmd_mknotpresent ARM: 8578/1: mm: ensure pmd_present only checks the valid bit
2 parents e80dac1 + 56530f5 commit c141afd

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

arch/arm/include/asm/pgtable-2level.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,7 @@ static inline pmd_t *pmd_offset(pud_t *pud, unsigned long addr)
193193

194194
#define pmd_large(pmd) (pmd_val(pmd) & 2)
195195
#define pmd_bad(pmd) (pmd_val(pmd) & 2)
196+
#define pmd_present(pmd) (pmd_val(pmd))
196197

197198
#define copy_pmd(pmdpd,pmdps) \
198199
do { \

arch/arm/include/asm/pgtable-3level.h

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -211,6 +211,7 @@ static inline pmd_t *pmd_offset(pud_t *pud, unsigned long addr)
211211
: !!(pmd_val(pmd) & (val)))
212212
#define pmd_isclear(pmd, val) (!(pmd_val(pmd) & (val)))
213213

214+
#define pmd_present(pmd) (pmd_isset((pmd), L_PMD_SECT_VALID))
214215
#define pmd_young(pmd) (pmd_isset((pmd), PMD_SECT_AF))
215216
#define pte_special(pte) (pte_isset((pte), L_PTE_SPECIAL))
216217
static inline pte_t pte_mkspecial(pte_t pte)
@@ -249,10 +250,10 @@ PMD_BIT_FUNC(mkyoung, |= PMD_SECT_AF);
249250
#define pfn_pmd(pfn,prot) (__pmd(((phys_addr_t)(pfn) << PAGE_SHIFT) | pgprot_val(prot)))
250251
#define mk_pmd(page,prot) pfn_pmd(page_to_pfn(page),prot)
251252

252-
/* represent a notpresent pmd by zero, this is used by pmdp_invalidate */
253+
/* represent a notpresent pmd by faulting entry, this is used by pmdp_invalidate */
253254
static inline pmd_t pmd_mknotpresent(pmd_t pmd)
254255
{
255-
return __pmd(0);
256+
return __pmd(pmd_val(pmd) & ~L_PMD_SECT_VALID);
256257
}
257258

258259
static inline pmd_t pmd_modify(pmd_t pmd, pgprot_t newprot)

arch/arm/include/asm/pgtable.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,6 @@ extern pgd_t swapper_pg_dir[PTRS_PER_PGD];
182182
#define pgd_offset_k(addr) pgd_offset(&init_mm, addr)
183183

184184
#define pmd_none(pmd) (!pmd_val(pmd))
185-
#define pmd_present(pmd) (pmd_val(pmd))
186185

187186
static inline pte_t *pmd_page_vaddr(pmd_t pmd)
188187
{

0 commit comments

Comments
 (0)