mm/filemap.c: remove useless check in pagecache_get_page()

Kirill Tkhai · torvalds · commit c16eb000ca03 · 2018-12-28T12:11:50.000-08:00
page always is not NULL, so we may remove this useless check. Link: http://lkml.kernel.org/r/154419752044.18559.2452963074922917720.stgit@localhost.localdomain Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com> Acked-by: Cyrill Gorcunov <gorcunov@gmail.com> Reviewed-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
diff --git a/mm/filemap.c b/mm/filemap.c
@@ -1601,7 +1601,7 @@ struct page *pagecache_get_page(struct address_space *mapping, pgoff_t offset,
 		VM_BUG_ON_PAGE(page->index != offset, page);
 	}
 
-	if (page && (fgp_flags & FGP_ACCESSED))
+	if (fgp_flags & FGP_ACCESSED)
 		mark_page_accessed(page);
 
 no_page:

Original file line number	Diff line number	Diff line change
`@@ -1601,7 +1601,7 @@ struct page pagecache_get_page(struct address_space mapping, pgoff_t offset,`
`1601`	`1601`	`VM_BUG_ON_PAGE(page->index != offset, page);`
`1602`	`1602`	`}`
`1603`	`1603`
`1604`		`- if (page && (fgp_flags & FGP_ACCESSED))`
	`1604`	`+ if (fgp_flags & FGP_ACCESSED)`
`1605`	`1605`	`mark_page_accessed(page);`
`1606`	`1606`
`1607`	`1607`	`no_page:`