Skip to content

Commit c251f15

Browse files
jbeulichDavid Vrabel
authored andcommitted
xenbus: check return value of xenbus_scanf()
Don't ignore errors here: Set backend state to unknown when unsuccessful. Signed-off-by: Jan Beulich <[email protected]> Signed-off-by: David Vrabel <[email protected]>
1 parent e1e5b3f commit c251f15

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

drivers/xen/xenbus/xenbus_probe_frontend.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,9 @@ static int backend_state;
335335
static void xenbus_reset_backend_state_changed(struct xenbus_watch *w,
336336
const char **v, unsigned int l)
337337
{
338-
xenbus_scanf(XBT_NIL, v[XS_WATCH_PATH], "", "%i", &backend_state);
338+
if (xenbus_scanf(XBT_NIL, v[XS_WATCH_PATH], "", "%i",
339+
&backend_state) != 1)
340+
backend_state = XenbusStateUnknown;
339341
printk(KERN_DEBUG "XENBUS: backend %s %s\n",
340342
v[XS_WATCH_PATH], xenbus_strstate(backend_state));
341343
wake_up(&backend_state_wq);

0 commit comments

Comments
 (0)