net/rds: Incorrect WARN_ON()

kcp-git · Somasundaram Krishnasamy · commit c2951b716433 · 2020-08-07T15:15:28.000-07:00
The WARN_ON() in rds_ib_free_caches() is incorrect as the code
cannot assume that there is only one device.

Orabug: 31718164

Signed-off-by: Ka-Cheong Poon &lt;ka-cheong.poon@oracle.com&gt;
Tested-by: Jenny Xu &lt;jenny.x.xu@oracle.com&gt;
Reviewed-by: Darren Kenny &lt;darren.kenny@oracle.com&gt;
Signed-off-by: Somasundaram Krishnasamy &lt;somasundaram.krishnasamy@oracle.com&gt;
diff --git a/net/rds/ib.c b/net/rds/ib.c
@@ -343,11 +343,6 @@ static void rds_ib_free_caches(struct rds_ib_device *rds_ibdev)
 
 		rds_ib_free_frag_cache(rds_ibdev->i_cache_frags + i, cache_sz);
 	}
-
-	/* If there is only 1 IB device, rds_ib_allocation should be 0
-	 * after the rds recv cache is freed.
-	 */
-	WARN_ON(atomic_read(&rds_ib_allocation));
 }
 
 void rds_ib_nodev_connect(void)

Original file line number	Diff line number	Diff line change
`@@ -343,11 +343,6 @@ static void rds_ib_free_caches(struct rds_ib_device *rds_ibdev)`
`343`	`343`
`344`	`344`	`rds_ib_free_frag_cache(rds_ibdev->i_cache_frags + i, cache_sz);`
`345`	`345`	`}`
`346`		`-`
`347`		`- /* If there is only 1 IB device, rds_ib_allocation should be 0`
`348`		`- * after the rds recv cache is freed.`
`349`		`- */`
`350`		`- WARN_ON(atomic_read(&rds_ib_allocation));`
`351`	`346`	`}`
`352`	`347`
`353`	`348`	`void rds_ib_nodev_connect(void)`