Skip to content

Commit c2e8fbf

Browse files
chenhuacaimartinkpetersen
authored andcommitted
scsi: libsas: align sata_device's rps_resp on a cacheline
The rps_resp buffer in ata_device is a DMA target, but it isn't explicitly cacheline aligned. Due to this, adjacent fields can be overwritten with stale data from memory on non-coherent architectures. As a result, the kernel is sometimes unable to communicate with an SATA device behind a SAS expander. Fix this by ensuring that the rps_resp buffer is cacheline aligned. This issue is similar to that fixed by Commit 84bda12 ("libata: align ap->sector_buf") and Commit 4ee34ea ("libata: Align ata_device's id on a cacheline"). Cc: [email protected] Signed-off-by: Huacai Chen <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]> Signed-off-by: Martin K. Petersen <[email protected]>
1 parent 90addc6 commit c2e8fbf

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

include/scsi/libsas.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,11 +159,11 @@ struct expander_device {
159159

160160
struct sata_device {
161161
unsigned int class;
162-
struct smp_resp rps_resp; /* report_phy_sata_resp */
163162
u8 port_no; /* port number, if this is a PM (Port) */
164163

165164
struct ata_port *ap;
166165
struct ata_host ata_host;
166+
struct smp_resp rps_resp ____cacheline_aligned; /* report_phy_sata_resp */
167167
u8 fis[ATA_RESP_FIS_SIZE];
168168
};
169169

0 commit comments

Comments
 (0)