Skip to content

Commit c3f4a16

Browse files
fdmananamasoncl
authored andcommitted
Btrfs: use kmem_cache_free when freeing entry in inode cache
The free space entries are allocated using kmem_cache_zalloc(), through __btrfs_add_free_space(), therefore we should use kmem_cache_free() and not kfree() to avoid any confusion and any potential problem. Looking at the kfree() definition at mm/slab.c it has the following comment: /* * (...) * * Don't free memory not originally allocated by kmalloc() * or you will run into trouble. */ So better be safe and use kmem_cache_free(). Cc: [email protected] Signed-off-by: Filipe Manana <[email protected]> Reviewed-by: David Sterba <[email protected]> Signed-off-by: Chris Mason <[email protected]>
1 parent 67c5e7d commit c3f4a16

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

fs/btrfs/inode-map.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ void btrfs_unpin_free_ino(struct btrfs_root *root)
271271
__btrfs_add_free_space(ctl, info->offset, count);
272272
free:
273273
rb_erase(&info->offset_index, rbroot);
274-
kfree(info);
274+
kmem_cache_free(btrfs_free_space_cachep, info);
275275
}
276276
}
277277

0 commit comments

Comments
 (0)