Skip to content

Commit c49cbc1

Browse files
vireshkrafaeljw
authored andcommitted
cpufreq: schedutil: Always process remote callback with slow switching
The frequency update from the utilization update handlers can be divided into two parts: (A) Finding the next frequency (B) Updating the frequency While any CPU can do (A), (B) can be restricted to a group of CPUs only, depending on the current platform. For platforms where fast cpufreq switching is possible, both (A) and (B) are always done from the same CPU and that CPU should be capable of changing the frequency of the target CPU. But for platforms where fast cpufreq switching isn't possible, after doing (A) we wake up a kthread which will eventually do (B). This kthread is already bound to the right set of CPUs, i.e. only those which can change the frequency of CPUs of a cpufreq policy. And so any CPU can actually do (A) in this case, as the frequency is updated from the right set of CPUs only. Check cpufreq_can_do_remote_dvfs() only for the fast switching case. Signed-off-by: Viresh Kumar <[email protected]> Signed-off-by: Rafael J. Wysocki <[email protected]>
1 parent e2cabe4 commit c49cbc1

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

kernel/sched/cpufreq_schedutil.c

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,13 +84,18 @@ static bool sugov_should_update_freq(struct sugov_policy *sg_policy, u64 time)
8484
*
8585
* However, drivers cannot in general deal with cross-cpu
8686
* requests, so while get_next_freq() will work, our
87-
* sugov_update_commit() call may not.
87+
* sugov_update_commit() call may not for the fast switching platforms.
8888
*
8989
* Hence stop here for remote requests if they aren't supported
9090
* by the hardware, as calculating the frequency is pointless if
9191
* we cannot in fact act on it.
92+
*
93+
* For the slow switching platforms, the kthread is always scheduled on
94+
* the right set of CPUs and any CPU can find the next frequency and
95+
* schedule the kthread.
9296
*/
93-
if (!cpufreq_can_do_remote_dvfs(sg_policy->policy))
97+
if (sg_policy->policy->fast_switch_enabled &&
98+
!cpufreq_can_do_remote_dvfs(sg_policy->policy))
9499
return false;
95100

96101
if (sg_policy->work_in_progress)

0 commit comments

Comments
 (0)