Skip to content

Commit c4c129d

Browse files
Gu JinXiangkdave
authored andcommitted
btrfs: drop unused parameter qgroup_reserved
Since commit 7775c81 ("btrfs: remove unused parameter from btrfs_subvolume_release_metadata") parameter qgroup_reserved is not used by caller of function btrfs_subvolume_reserve_metadata. So remove it. Signed-off-by: Gu JinXiang <[email protected]> Reviewed-by: David Sterba <[email protected]> Signed-off-by: David Sterba <[email protected]>
1 parent e73e81b commit c4c129d

File tree

4 files changed

+5
-14
lines changed

4 files changed

+5
-14
lines changed

fs/btrfs/ctree.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2767,8 +2767,7 @@ void btrfs_free_reserved_data_space_noquota(struct inode *inode, u64 start,
27672767
void btrfs_trans_release_chunk_metadata(struct btrfs_trans_handle *trans);
27682768
int btrfs_subvolume_reserve_metadata(struct btrfs_root *root,
27692769
struct btrfs_block_rsv *rsv,
2770-
int nitems,
2771-
u64 *qgroup_reserved, bool use_global_rsv);
2770+
int nitems, bool use_global_rsv);
27722771
void btrfs_subvolume_release_metadata(struct btrfs_fs_info *fs_info,
27732772
struct btrfs_block_rsv *rsv);
27742773
void btrfs_delalloc_release_extents(struct btrfs_inode *inode, u64 num_bytes,

fs/btrfs/extent-tree.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5947,7 +5947,6 @@ void btrfs_trans_release_chunk_metadata(struct btrfs_trans_handle *trans)
59475947
int btrfs_subvolume_reserve_metadata(struct btrfs_root *root,
59485948
struct btrfs_block_rsv *rsv,
59495949
int items,
5950-
u64 *qgroup_reserved,
59515950
bool use_global_rsv)
59525951
{
59535952
u64 num_bytes;
@@ -5965,8 +5964,6 @@ int btrfs_subvolume_reserve_metadata(struct btrfs_root *root,
59655964
num_bytes = 0;
59665965
}
59675966

5968-
*qgroup_reserved = num_bytes;
5969-
59705967
num_bytes = btrfs_calc_trans_metadata_size(fs_info, items);
59715968
rsv->space_info = __find_space_info(fs_info,
59725969
BTRFS_BLOCK_GROUP_METADATA);
@@ -5976,8 +5973,8 @@ int btrfs_subvolume_reserve_metadata(struct btrfs_root *root,
59765973
if (ret == -ENOSPC && use_global_rsv)
59775974
ret = btrfs_block_rsv_migrate(global_rsv, rsv, num_bytes, 1);
59785975

5979-
if (ret && *qgroup_reserved)
5980-
btrfs_qgroup_free_meta_prealloc(root, *qgroup_reserved);
5976+
if (ret && num_bytes)
5977+
btrfs_qgroup_free_meta_prealloc(root, num_bytes);
59815978

59825979
return ret;
59835980
}

fs/btrfs/inode.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4293,7 +4293,6 @@ int btrfs_delete_subvolume(struct inode *dir, struct dentry *dentry)
42934293
struct btrfs_trans_handle *trans;
42944294
struct btrfs_block_rsv block_rsv;
42954295
u64 root_flags;
4296-
u64 qgroup_reserved;
42974296
int ret;
42984297
int err;
42994298

@@ -4328,8 +4327,7 @@ int btrfs_delete_subvolume(struct inode *dir, struct dentry *dentry)
43284327
* two for dir entries,
43294328
* two for root ref/backref.
43304329
*/
4331-
err = btrfs_subvolume_reserve_metadata(root, &block_rsv,
4332-
5, &qgroup_reserved, true);
4330+
err = btrfs_subvolume_reserve_metadata(root, &block_rsv, 5, true);
43334331
if (err)
43344332
goto out_up_write;
43354333

fs/btrfs/ioctl.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -569,7 +569,6 @@ static noinline int create_subvol(struct inode *dir,
569569
u64 objectid;
570570
u64 new_dirid = BTRFS_FIRST_FREE_OBJECTID;
571571
u64 index = 0;
572-
u64 qgroup_reserved;
573572
uuid_le new_uuid;
574573

575574
root_item = kzalloc(sizeof(*root_item), GFP_KERNEL);
@@ -594,8 +593,7 @@ static noinline int create_subvol(struct inode *dir,
594593
* The same as the snapshot creation, please see the comment
595594
* of create_snapshot().
596595
*/
597-
ret = btrfs_subvolume_reserve_metadata(root, &block_rsv,
598-
8, &qgroup_reserved, false);
596+
ret = btrfs_subvolume_reserve_metadata(root, &block_rsv, 8, false);
599597
if (ret)
600598
goto fail_free;
601599

@@ -803,7 +801,6 @@ static int create_snapshot(struct btrfs_root *root, struct inode *dir,
803801
*/
804802
ret = btrfs_subvolume_reserve_metadata(BTRFS_I(dir)->root,
805803
&pending_snapshot->block_rsv, 8,
806-
&pending_snapshot->qgroup_reserved,
807804
false);
808805
if (ret)
809806
goto dec_and_free;

0 commit comments

Comments
 (0)