Skip to content

Commit c4e4fcc

Browse files
Wayne LinLyude
authored andcommitted
drm/dp_mst: correct the shifting in DP_REMOTE_I2C_READ
[Why] According to DP spec, it should shift left 4 digits for NO_STOP_BIT in REMOTE_I2C_READ message. Not 5 digits. In current code, NO_STOP_BIT is always set to zero which means I2C master is always generating a I2C stop at the end of each I2C write transaction while handling REMOTE_I2C_READ sideband message. This issue might have the generated I2C signal not meeting the requirement. Take random read in I2C for instance, I2C master should generate a repeat start to start to read data after writing the read address. This issue will cause the I2C master to generate a stop-start rather than a re-start which is not expected in I2C random read. [How] Correct the shifting value of NO_STOP_BIT for DP_REMOTE_I2C_READ case in drm_dp_encode_sideband_req(). Changes since v1:(https://patchwork.kernel.org/patch/11312667/) * Add more descriptions in commit and cc to stable Fixes: ad7f8a1 ("drm/helper: add Displayport multi-stream helper (v0.6)") Reviewed-by: Harry Wentland <[email protected]> Signed-off-by: Wayne Lin <[email protected]> Cc: [email protected] Signed-off-by: Lyude Paul <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent ac2917b commit c4e4fcc

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/drm_dp_mst_topology.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -393,7 +393,7 @@ drm_dp_encode_sideband_req(const struct drm_dp_sideband_msg_req_body *req,
393393
memcpy(&buf[idx], req->u.i2c_read.transactions[i].bytes, req->u.i2c_read.transactions[i].num_bytes);
394394
idx += req->u.i2c_read.transactions[i].num_bytes;
395395

396-
buf[idx] = (req->u.i2c_read.transactions[i].no_stop_bit & 0x1) << 5;
396+
buf[idx] = (req->u.i2c_read.transactions[i].no_stop_bit & 0x1) << 4;
397397
buf[idx] |= (req->u.i2c_read.transactions[i].i2c_transaction_delay & 0xf);
398398
idx++;
399399
}

0 commit comments

Comments
 (0)