Skip to content

Commit c52c545

Browse files
goldelicodtor
authored andcommitted
Input: twl6040-vibra - fix DT node memory management
commit e7ec014 ("Input: twl6040-vibra - update for device tree support") made the separate vibra DT node to a subnode of the twl6040. It now calls of_find_node_by_name() to locate the "vibra" subnode. This function has a side effect to call of_node_put on() for the twl6040 parent node passed in as a parameter. This causes trouble later on. Solution: we must call of_node_get() before of_find_node_by_name() Signed-off-by: H. Nikolaus Schaller <[email protected]> Signed-off-by: Dmitry Torokhov <[email protected]>
1 parent 6ae645d commit c52c545

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/input/misc/twl6040-vibra.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -257,6 +257,7 @@ static int twl6040_vibra_probe(struct platform_device *pdev)
257257
int vddvibr_uV = 0;
258258
int error;
259259

260+
of_node_get(twl6040_core_dev->of_node);
260261
twl6040_core_node = of_find_node_by_name(twl6040_core_dev->of_node,
261262
"vibra");
262263
if (!twl6040_core_node) {

0 commit comments

Comments
 (0)