rds: Cancel pending connections on connection request

RDS connections can enter the RDS_CONN_CONNECTING state in two ways:
1. It can be started using the connection workqueue (this can happen
both on queue_reconnect and upon send if the workqueue is not up)
2. It can enter the RDS_CONN_CONNECTING state due to an incoming
connection request

In case RDS connections enter RDS_CONN_CONNECTION state due to an incoming
connection request, the connection workqueue might already be scheduled. In
this case the connection workqueue needs to be cancelled.

Failure to do so might result in messages like the following in the kernel
trace buffer:

cannot transition from allegedly DOWN(act RDS_CONN_UP) to CONNECTING state

Orabug: 30473443

Signed-off-by: Dag Moxnes <[email protected]>
Reviewed-by: Håkon Bugge <[email protected]>
Signed-off-by: Somasundaram Krishnasamy <[email protected]>

Author: Dag Moxnes

net/rds/ib_cm.c

@@ -1261,6 +1261,12 @@ int rds_ib_cm_handle_connect(struct rdma_cm_id *cm_id,
 		if (ic && cm_seq_check_enable)
 			ic->i_last_rej_seq = cm_req_seq;
 		goto out;
+	} else {
+		/* Cancel any pending reconnect */
+		struct rds_conn_path *cp = &conn->c_path[0];
+
+		cancel_delayed_work_sync(&cp->cp_conn_w);
+		rds_clear_reconnect_pending_work_bit(cp);
 	}
 
 	ic = conn->c_transport_data;