Skip to content

Commit c60c32a

Browse files
Sebastian Andrzej SiewiorKAGA-KOKO
authored andcommitted
posix-cpu-timers: Remove lockdep_assert_irqs_disabled()
The lockdep_assert_irqs_disabled() was a BUG_ON() statement in the beginning and it was added just before the "spin_lock(siglock)" statement to ensure this lock was taken with disabled interrupts. This is no longer the case: the siglock is acquired via lock_task_sighand() and this function already disables the interrupts. The lock is also acquired before this "lockdep_assert_irqs_disabled" so it is best to remove it. Signed-off-by: Sebastian Andrzej Siewior <[email protected]> Signed-off-by: Thomas Gleixner <[email protected]> Cc: Frederic Weisbecker <[email protected]> Link: https://lkml.kernel.org/[email protected]
1 parent d82991a commit c60c32a

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

kernel/time/posix-cpu-timers.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -604,7 +604,6 @@ static int posix_cpu_timer_set(struct k_itimer *timer, int timer_flags,
604604
/*
605605
* Disarm any old timer after extracting its expiry time.
606606
*/
607-
lockdep_assert_irqs_disabled();
608607

609608
ret = 0;
610609
old_incr = timer->it.cpu.incr;
@@ -1049,7 +1048,6 @@ static void posix_cpu_timer_rearm(struct k_itimer *timer)
10491048
/*
10501049
* Now re-arm for the new expiry time.
10511050
*/
1052-
lockdep_assert_irqs_disabled();
10531051
arm_timer(timer);
10541052
unlock:
10551053
unlock_task_sighand(p, &flags);

0 commit comments

Comments
 (0)