Skip to content

Commit c63c4ed

Browse files
committed
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input: Input: sentelic - fix retrieving number of buttons Input: sentelic - release mutex upon register write failure
2 parents d65616a + 6ccbcf2 commit c63c4ed

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

drivers/input/mouse/sentelic.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
* Finger Sensing Pad PS/2 mouse driver.
33
*
44
* Copyright (C) 2005-2007 Asia Vital Components Co., Ltd.
5-
* Copyright (C) 2005-2010 Tai-hwa Liang, Sentelic Corporation.
5+
* Copyright (C) 2005-2011 Tai-hwa Liang, Sentelic Corporation.
66
*
77
* This program is free software; you can redistribute it and/or
88
* modify it under the terms of the GNU General Public License
@@ -162,7 +162,7 @@ static int fsp_reg_write(struct psmouse *psmouse, int reg_addr, int reg_val)
162162
ps2_sendbyte(ps2dev, v, FSP_CMD_TIMEOUT2);
163163

164164
if (ps2_sendbyte(ps2dev, 0xf3, FSP_CMD_TIMEOUT) < 0)
165-
return -1;
165+
goto out;
166166

167167
if ((v = fsp_test_invert_cmd(reg_val)) != reg_val) {
168168
/* inversion is required */
@@ -261,7 +261,7 @@ static int fsp_page_reg_write(struct psmouse *psmouse, int reg_val)
261261
ps2_sendbyte(ps2dev, 0x88, FSP_CMD_TIMEOUT2);
262262

263263
if (ps2_sendbyte(ps2dev, 0xf3, FSP_CMD_TIMEOUT) < 0)
264-
return -1;
264+
goto out;
265265

266266
if ((v = fsp_test_invert_cmd(reg_val)) != reg_val) {
267267
ps2_sendbyte(ps2dev, 0x47, FSP_CMD_TIMEOUT2);
@@ -309,7 +309,7 @@ static int fsp_get_buttons(struct psmouse *psmouse, int *btn)
309309
};
310310
int val;
311311

312-
if (fsp_reg_read(psmouse, FSP_REG_TMOD_STATUS1, &val) == -1)
312+
if (fsp_reg_read(psmouse, FSP_REG_TMOD_STATUS, &val) == -1)
313313
return -EIO;
314314

315315
*btn = buttons[(val & 0x30) >> 4];

drivers/input/mouse/sentelic.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
* Finger Sensing Pad PS/2 mouse driver.
33
*
44
* Copyright (C) 2005-2007 Asia Vital Components Co., Ltd.
5-
* Copyright (C) 2005-2009 Tai-hwa Liang, Sentelic Corporation.
5+
* Copyright (C) 2005-2011 Tai-hwa Liang, Sentelic Corporation.
66
*
77
* This program is free software; you can redistribute it and/or
88
* modify it under the terms of the GNU General Public License
@@ -33,6 +33,7 @@
3333
/* Finger-sensing Pad control registers */
3434
#define FSP_REG_SYSCTL1 0x10
3535
#define FSP_BIT_EN_REG_CLK BIT(5)
36+
#define FSP_REG_TMOD_STATUS 0x20
3637
#define FSP_REG_OPC_QDOWN 0x31
3738
#define FSP_BIT_EN_OPC_TAG BIT(7)
3839
#define FSP_REG_OPTZ_XLO 0x34

0 commit comments

Comments
 (0)