Skip to content

Commit c6936e7

Browse files
Christof SchmittJames Bottomley
authored andcommitted
[SCSI] zfcp: Fix abort handler for completions in progress
When the abort handler cannot find a pending FSF request, the request completion could just be running. This means we cannot return SUCCESS, since this would lead to call to scsi_done after exiting the SCSI error handler which is not allowed. Reviewed-by: Martin Petermann <[email protected]> Signed-off-by: Christof Schmitt <[email protected]> Signed-off-by: James Bottomley <[email protected]>
1 parent 5b43e71 commit c6936e7

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/s390/scsi/zfcp_scsi.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ static int zfcp_scsi_eh_abort_handler(struct scsi_cmnd *scpnt)
171171
write_unlock_irqrestore(&adapter->abort_lock, flags);
172172
zfcp_scsi_dbf_event_abort("lte1", adapter, scpnt, NULL,
173173
old_req_id);
174-
return SUCCESS;
174+
return FAILED; /* completion could be in progress */
175175
}
176176
old_req->data = NULL;
177177

0 commit comments

Comments
 (0)