Skip to content

Commit c6f5c93

Browse files
committed
Merge branch 'for-3.4' of git://linux-nfs.org/~bfields/linux
Pull nfsd bugfixes from J. Bruce Fields: "One bugfix, and one minor header fix from Jeff Layton while we're here" * 'for-3.4' of git://linux-nfs.org/~bfields/linux: nfsd: include cld.h in the headers_install target nfsd: don't fail unchecked creates of non-special files
2 parents 1985330 + d22053c commit c6f5c93

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

fs/nfsd/nfs4proc.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -235,15 +235,15 @@ do_open_lookup(struct svc_rqst *rqstp, struct svc_fh *current_fh, struct nfsd4_o
235235
*/
236236
if (open->op_createmode == NFS4_CREATE_EXCLUSIVE && status == 0)
237237
open->op_bmval[1] = (FATTR4_WORD1_TIME_ACCESS |
238-
FATTR4_WORD1_TIME_MODIFY);
238+
FATTR4_WORD1_TIME_MODIFY);
239239
} else {
240240
status = nfsd_lookup(rqstp, current_fh,
241241
open->op_fname.data, open->op_fname.len, resfh);
242242
fh_unlock(current_fh);
243-
if (status)
244-
goto out;
245-
status = nfsd_check_obj_isreg(resfh);
246243
}
244+
if (status)
245+
goto out;
246+
status = nfsd_check_obj_isreg(resfh);
247247
if (status)
248248
goto out;
249249

fs/nfsd/vfs.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1458,7 +1458,7 @@ do_nfsd_create(struct svc_rqst *rqstp, struct svc_fh *fhp,
14581458
switch (createmode) {
14591459
case NFS3_CREATE_UNCHECKED:
14601460
if (! S_ISREG(dchild->d_inode->i_mode))
1461-
err = nfserr_exist;
1461+
goto out;
14621462
else if (truncp) {
14631463
/* in nfsv4, we need to treat this case a little
14641464
* differently. we don't want to truncate the

include/linux/nfsd/Kbuild

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
header-y += cld.h
12
header-y += debug.h
23
header-y += export.h
34
header-y += nfsfh.h

0 commit comments

Comments
 (0)