Skip to content

Commit c7f7ba8

Browse files
roidayanSaeed Mahameed
authored andcommitted
net/mlx5e: Remove redundant WARN when we cannot find neigh entry
It is possible for neigh entry not to exist if it was cleaned already. When we bring down an interface the neigh gets deleted but it could be that our listener for neigh event to clear the encap valid bit didn't start yet and the neigh update last used work is started first. In this scenario the encap entry has valid bit set but the neigh entry doesn't exist. Signed-off-by: Roi Dayan <[email protected]> Reviewed-by: Paul Blakey <[email protected]> Signed-off-by: Saeed Mahameed <[email protected]>
1 parent 3101d1f commit c7f7ba8

File tree

1 file changed

+1
-3
lines changed
  • drivers/net/ethernet/mellanox/mlx5/core

1 file changed

+1
-3
lines changed

drivers/net/ethernet/mellanox/mlx5/core/en_tc.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1032,10 +1032,8 @@ void mlx5e_tc_update_neigh_used_value(struct mlx5e_neigh_hash_entry *nhe)
10321032
* dst ip pair
10331033
*/
10341034
n = neigh_lookup(tbl, &m_neigh->dst_ip, m_neigh->dev);
1035-
if (!n) {
1036-
WARN(1, "The neighbour already freed\n");
1035+
if (!n)
10371036
return;
1038-
}
10391037

10401038
neigh_event_send(n, NULL);
10411039
neigh_release(n);

0 commit comments

Comments
 (0)