Skip to content

Commit c83ae15

Browse files
committed
Merge branch 'samples/bpf: xdpsock: Minor enhancements'
Simon Horman says: ==================== This short series provides minor enhancements to the sample code in samples/bpf/xdpsock_user.c. Each change is explained more fully in its own commit message. ==================== Signed-off-by: Andrii Nakryiko <[email protected]>
2 parents 579345e + f4700a6 commit c83ae15

File tree

1 file changed

+8
-12
lines changed

1 file changed

+8
-12
lines changed

samples/bpf/xdpsock_user.c

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
11
// SPDX-License-Identifier: GPL-2.0
22
/* Copyright(c) 2017 - 2018 Intel Corporation. */
33

4-
#include <asm/barrier.h>
54
#include <errno.h>
65
#include <getopt.h>
76
#include <libgen.h>
87
#include <linux/bpf.h>
9-
#include <linux/compiler.h>
108
#include <linux/if_link.h>
119
#include <linux/if_xdp.h>
1210
#include <linux/if_ether.h>
@@ -653,17 +651,15 @@ static unsigned int do_csum(const unsigned char *buff, int len)
653651
return result;
654652
}
655653

656-
__sum16 ip_fast_csum(const void *iph, unsigned int ihl);
657-
658654
/*
659655
* This is a version of ip_compute_csum() optimized for IP headers,
660656
* which always checksum on 4 octet boundaries.
661657
* This function code has been taken from
662658
* Linux kernel lib/checksum.c
663659
*/
664-
__sum16 ip_fast_csum(const void *iph, unsigned int ihl)
660+
static inline __sum16 ip_fast_csum(const void *iph, unsigned int ihl)
665661
{
666-
return (__force __sum16)~do_csum(iph, ihl * 4);
662+
return (__sum16)~do_csum(iph, ihl * 4);
667663
}
668664

669665
/*
@@ -673,11 +669,11 @@ __sum16 ip_fast_csum(const void *iph, unsigned int ihl)
673669
*/
674670
static inline __sum16 csum_fold(__wsum csum)
675671
{
676-
u32 sum = (__force u32)csum;
672+
u32 sum = (u32)csum;
677673

678674
sum = (sum & 0xffff) + (sum >> 16);
679675
sum = (sum & 0xffff) + (sum >> 16);
680-
return (__force __sum16)~sum;
676+
return (__sum16)~sum;
681677
}
682678

683679
/*
@@ -703,16 +699,16 @@ __wsum csum_tcpudp_nofold(__be32 saddr, __be32 daddr,
703699
__wsum csum_tcpudp_nofold(__be32 saddr, __be32 daddr,
704700
__u32 len, __u8 proto, __wsum sum)
705701
{
706-
unsigned long long s = (__force u32)sum;
702+
unsigned long long s = (u32)sum;
707703

708-
s += (__force u32)saddr;
709-
s += (__force u32)daddr;
704+
s += (u32)saddr;
705+
s += (u32)daddr;
710706
#ifdef __BIG_ENDIAN__
711707
s += proto + len;
712708
#else
713709
s += (proto + len) << 8;
714710
#endif
715-
return (__force __wsum)from64to32(s);
711+
return (__wsum)from64to32(s);
716712
}
717713

718714
/*

0 commit comments

Comments
 (0)