Skip to content

Commit c88c157

Browse files
Chen Jiahaokuba-moo
authored andcommitted
net: bcmasp: Clean up redundant dev_err_probe()
Referring to platform_get_irq()'s definition, the return value has already been checked, error message also been printed via dev_err_probe() if ret < 0. Calling dev_err_probe() one more time outside platform_get_irq() is obviously redundant. Removing dev_err_probe() outside platform_get_irq() to clean up above problem. Signed-off-by: Chen Jiahao <[email protected]> Reviewed-by: Simon Horman <[email protected]> Acked-by: Justin Chen <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 61c5145 commit c88c157

File tree

1 file changed

+1
-1
lines changed
  • drivers/net/ethernet/broadcom/asp2

1 file changed

+1
-1
lines changed

drivers/net/ethernet/broadcom/asp2/bcmasp.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1232,7 +1232,7 @@ static int bcmasp_probe(struct platform_device *pdev)
12321232

12331233
priv->irq = platform_get_irq(pdev, 0);
12341234
if (priv->irq <= 0)
1235-
return dev_err_probe(dev, -EINVAL, "invalid interrupt\n");
1235+
return -EINVAL;
12361236

12371237
priv->clk = devm_clk_get_optional_enabled(dev, "sw_asp");
12381238
if (IS_ERR(priv->clk))

0 commit comments

Comments
 (0)