Skip to content

Commit c8b359d

Browse files
kovalev0amir73il
authored andcommitted
ovl: Filter invalid inodes with missing lookup function
Add a check to the ovl_dentry_weird() function to prevent the processing of directory inodes that lack the lookup function. This is important because such inodes can cause errors in overlayfs when passed to the lowerstack. Reported-by: [email protected] Link: https://syzkaller.appspot.com/bug?extid=a8c9d476508bd14a90e5 Suggested-by: Miklos Szeredi <[email protected]> Link: https://lore.kernel.org/linux-unionfs/CAJfpegvx-oS9XGuwpJx=Xe28_jzWx5eRo1y900_ZzWY+=gGzUg@mail.gmail.com/ Signed-off-by: Vasiliy Kovalev <[email protected]> Cc: <[email protected]> Signed-off-by: Amir Goldstein <[email protected]>
1 parent d66907b commit c8b359d

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

fs/overlayfs/util.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,9 @@ void ovl_dentry_init_flags(struct dentry *dentry, struct dentry *upperdentry,
202202

203203
bool ovl_dentry_weird(struct dentry *dentry)
204204
{
205+
if (!d_can_lookup(dentry) && !d_is_file(dentry) && !d_is_symlink(dentry))
206+
return true;
207+
205208
return dentry->d_flags & (DCACHE_NEED_AUTOMOUNT |
206209
DCACHE_MANAGE_TRANSIT |
207210
DCACHE_OP_HASH |

0 commit comments

Comments
 (0)