Skip to content

Commit c8ed563

Browse files
jacob-kellerJeff Kirsher
authored andcommitted
fm10k: free MBX IRQ before clearing interrupt scheme
During fm10k_io_error_detected we were clearing the interrupt scheme before we freed the MBX IRQ. This causes a kernel panic because the MBX IRQ are assigned after MSI-X initialization. Clearing the interrupt scheme results in removing the MSI-X entry table. Fix this by freeing the MBX IRQ before we clear the interrupt scheme, as we do elsewhere in the driver. Signed-off-by: Jacob Keller <[email protected]> Tested-by: Krishneil Singh <[email protected]> Signed-off-by: Jeff Kirsher <[email protected]>
1 parent 61e0217 commit c8ed563

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/net/ethernet/intel/fm10k/fm10k_pci.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2274,11 +2274,11 @@ static pci_ers_result_t fm10k_io_error_detected(struct pci_dev *pdev,
22742274
if (netif_running(netdev))
22752275
fm10k_close(netdev);
22762276

2277+
fm10k_mbx_free_irq(interface);
2278+
22772279
/* free interrupts */
22782280
fm10k_clear_queueing_scheme(interface);
22792281

2280-
fm10k_mbx_free_irq(interface);
2281-
22822282
pci_disable_device(pdev);
22832283

22842284
/* Request a slot reset. */

0 commit comments

Comments
 (0)