Skip to content

Commit c8f4c36

Browse files
lorddoskiasaxboe
authored andcommitted
direct-io: Remove unused DIO_ASYNC_EXTEND flag
This flag was added by 6039257 ("direct-io: add flag to allow aio writes beyond i_size") to support XFS. However, with the rework of XFS' DIO's path to use iomap in acdda3a ("xfs: use iomap_dio_rw") it became redundant. So let's remove it. Reviewed-by: Christoph Hellwig <[email protected]> Signed-off-by: Nikolay Borisov <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
1 parent fc9de9a commit c8f4c36

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

fs/direct-io.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1252,8 +1252,7 @@ do_blockdev_direct_IO(struct kiocb *iocb, struct inode *inode,
12521252
*/
12531253
if (is_sync_kiocb(iocb))
12541254
dio->is_async = false;
1255-
else if (!(dio->flags & DIO_ASYNC_EXTEND) &&
1256-
iov_iter_rw(iter) == WRITE && end > i_size_read(inode))
1255+
else if (iov_iter_rw(iter) == WRITE && end > i_size_read(inode))
12571256
dio->is_async = false;
12581257
else
12591258
dio->is_async = true;

include/linux/fs.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2977,9 +2977,6 @@ enum {
29772977
/* filesystem does not support filling holes */
29782978
DIO_SKIP_HOLES = 0x02,
29792979

2980-
/* filesystem can handle aio writes beyond i_size */
2981-
DIO_ASYNC_EXTEND = 0x04,
2982-
29832980
/* inode/fs/bdev does not need truncate protection */
29842981
DIO_SKIP_DIO_COUNT = 0x08,
29852982
};

0 commit comments

Comments
 (0)