Skip to content

Commit c99c287

Browse files
Intiyaz Bashadavem330
authored andcommitted
liquidio: fix wrong info about vf rx/tx ring parameters reported to ethtool
Information reported to ethtool about vf rx/tx ring parameters is wrong. Fix it by adding the missing initializations. Signed-off-by: Intiyaz Basha <[email protected]> Signed-off-by: Felix Manlunas <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent db53dce commit c99c287

File tree

1 file changed

+9
-21
lines changed

1 file changed

+9
-21
lines changed

drivers/net/ethernet/cavium/liquidio/lio_ethtool.c

Lines changed: 9 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -649,33 +649,21 @@ lio_ethtool_get_ringparam(struct net_device *netdev,
649649
rx_max_pending = CN6XXX_MAX_OQ_DESCRIPTORS;
650650
rx_pending = CFG_GET_NUM_RX_DESCS_NIC_IF(conf6x, lio->ifidx);
651651
tx_pending = CFG_GET_NUM_TX_DESCS_NIC_IF(conf6x, lio->ifidx);
652-
} else if (OCTEON_CN23XX_PF(oct)) {
653-
struct octeon_config *conf23 = CHIP_CONF(oct, cn23xx_pf);
654-
652+
} else if (OCTEON_CN23XX_PF(oct) || OCTEON_CN23XX_VF(oct)) {
655653
tx_max_pending = CN23XX_MAX_IQ_DESCRIPTORS;
656654
rx_max_pending = CN23XX_MAX_OQ_DESCRIPTORS;
657-
rx_pending = CFG_GET_NUM_RX_DESCS_NIC_IF(conf23, lio->ifidx);
658-
tx_pending = CFG_GET_NUM_TX_DESCS_NIC_IF(conf23, lio->ifidx);
659-
}
660-
661-
if (lio->mtu > OCTNET_DEFAULT_FRM_SIZE - OCTNET_FRM_HEADER_SIZE) {
662-
ering->rx_pending = 0;
663-
ering->rx_max_pending = 0;
664-
ering->rx_mini_pending = 0;
665-
ering->rx_jumbo_pending = rx_pending;
666-
ering->rx_mini_max_pending = 0;
667-
ering->rx_jumbo_max_pending = rx_max_pending;
668-
} else {
669-
ering->rx_pending = rx_pending;
670-
ering->rx_max_pending = rx_max_pending;
671-
ering->rx_mini_pending = 0;
672-
ering->rx_jumbo_pending = 0;
673-
ering->rx_mini_max_pending = 0;
674-
ering->rx_jumbo_max_pending = 0;
655+
rx_pending = oct->droq[0]->max_count;
656+
tx_pending = oct->instr_queue[0]->max_count;
675657
}
676658

677659
ering->tx_pending = tx_pending;
678660
ering->tx_max_pending = tx_max_pending;
661+
ering->rx_pending = rx_pending;
662+
ering->rx_max_pending = rx_max_pending;
663+
ering->rx_mini_pending = 0;
664+
ering->rx_jumbo_pending = 0;
665+
ering->rx_mini_max_pending = 0;
666+
ering->rx_jumbo_max_pending = 0;
679667
}
680668

681669
static u32 lio_get_msglevel(struct net_device *netdev)

0 commit comments

Comments
 (0)