Skip to content

Commit c9a5e6a

Browse files
committed
dm snapshot: remove stale FIXME in snapshot_map()
Commit ae1093b ("dm snapshot: use mutex instead of rw_semaphore") eliminated the need to worry about read vs write locking. So remove a FIXME in snapshot_map() that is concerned about selectively taking a write lock. Signed-off-by: Mike Snitzer <[email protected]>
1 parent 3db2776 commit c9a5e6a

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

drivers/md/dm-snap.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1707,8 +1707,6 @@ static int snapshot_map(struct dm_target *ti, struct bio *bio)
17071707
if (!s->valid)
17081708
return DM_MAPIO_KILL;
17091709

1710-
/* FIXME: should only take write lock if we need
1711-
* to copy an exception */
17121710
mutex_lock(&s->lock);
17131711

17141712
if (!s->valid || (unlikely(s->snapshot_overflowed) &&

0 commit comments

Comments
 (0)