net: fsl/fman: fix fixed-link-phydev reference leak

jhovold · davem330 · commit cb1f3410ff12 · 2016-11-27T20:01:15.000-05:00
Make sure to drop the reference taken by of_phy_find_device() when looking up a fixed-link phydev during probe. Fixes: 57ba4c9 ("fsl/fman: Add FMan MAC support") Signed-off-by: Johan Hovold <johan@kernel.org> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/drivers/net/ethernet/freescale/fman/mac.c b/drivers/net/ethernet/freescale/fman/mac.c
@@ -892,6 +892,8 @@ static int mac_probe(struct platform_device *_of_dev)
 		priv->fixed_link->duplex = phy->duplex;
 		priv->fixed_link->pause = phy->pause;
 		priv->fixed_link->asym_pause = phy->asym_pause;
+
+		put_device(&phy->mdio.dev);
 	}
 
 	err = mac_dev->init(mac_dev);

Original file line number	Diff line number	Diff line change
`@@ -892,6 +892,8 @@ static int mac_probe(struct platform_device *_of_dev)`
`892`	`892`	`priv->fixed_link->duplex = phy->duplex;`
`893`	`893`	`priv->fixed_link->pause = phy->pause;`
`894`	`894`	`priv->fixed_link->asym_pause = phy->asym_pause;`
	`895`	`+`
	`896`	`+ put_device(&phy->mdio.dev);`
`895`	`897`	`}`
`896`	`898`
`897`	`899`	`err = mac_dev->init(mac_dev);`