Skip to content

Commit cb773df

Browse files
hnaztorvalds
authored andcommitted
cgroup: remove unnecessary 0 check from css_from_id()
css_idr allocation starts at 1, so index 0 will never point to an item. css_from_id() currently filters that before asking idr_find(), but idr_find() would also just return NULL, so this is not needed. Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Johannes Weiner <[email protected]> Cc: Vladimir Davydov <[email protected]> Cc: Tejun Heo <[email protected]> Cc: Nikolay Borisov <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent 1fe4d02 commit cb773df

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

kernel/cgroup.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6166,7 +6166,7 @@ struct cgroup_subsys_state *css_tryget_online_from_dir(struct dentry *dentry,
61666166
struct cgroup_subsys_state *css_from_id(int id, struct cgroup_subsys *ss)
61676167
{
61686168
WARN_ON_ONCE(!rcu_read_lock_held());
6169-
return id > 0 ? idr_find(&ss->css_idr, id) : NULL;
6169+
return idr_find(&ss->css_idr, id);
61706170
}
61716171

61726172
/**

0 commit comments

Comments
 (0)