Skip to content

Commit cbf9256

Browse files
rddunlapjwrdegoede
authored andcommitted
platform/mellanox: tmfifo: fix kernel-doc warnings
Fix kernel-doc notation for structs and struct members to prevent these warnings: mlxbf-tmfifo.c:73: warning: cannot understand function prototype: 'struct mlxbf_tmfifo_vring ' mlxbf-tmfifo.c:128: warning: cannot understand function prototype: 'struct mlxbf_tmfifo_vdev ' mlxbf-tmfifo.c:146: warning: cannot understand function prototype: 'struct mlxbf_tmfifo_irq_info ' mlxbf-tmfifo.c:158: warning: cannot understand function prototype: 'struct mlxbf_tmfifo_io ' mlxbf-tmfifo.c:182: warning: cannot understand function prototype: 'struct mlxbf_tmfifo ' mlxbf-tmfifo.c:208: warning: cannot understand function prototype: 'struct mlxbf_tmfifo_msg_hdr ' mlxbf-tmfifo.c:138: warning: Function parameter or member 'config' not described in 'mlxbf_tmfifo_vdev' mlxbf-tmfifo.c:212: warning: Function parameter or member 'unused' not described in 'mlxbf_tmfifo_msg_hdr' Fixes: 1357dfd ("platform/mellanox: Add TmFifo driver for Mellanox BlueField Soc") Fixes: bc05ea6 ("platform/mellanox: Add BlueField-3 support in the tmfifo driver") Signed-off-by: Randy Dunlap <[email protected]> Reported-by: kernel test robot <[email protected]> Closes: lore.kernel.org/r/[email protected] Cc: Liming Sun <[email protected]> Cc: Hans de Goede <[email protected]> Cc: Ilpo Järvinen <[email protected]> Cc: Mark Gross <[email protected]> Cc: Vadim Pasternak <[email protected]> Cc: [email protected] Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Hans de Goede <[email protected]>
1 parent 2545deb commit cbf9256

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

drivers/platform/mellanox/mlxbf-tmfifo.c

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
struct mlxbf_tmfifo;
5454

5555
/**
56-
* mlxbf_tmfifo_vring - Structure of the TmFifo virtual ring
56+
* struct mlxbf_tmfifo_vring - Structure of the TmFifo virtual ring
5757
* @va: virtual address of the ring
5858
* @dma: dma address of the ring
5959
* @vq: pointer to the virtio virtqueue
@@ -113,12 +113,13 @@ enum {
113113
};
114114

115115
/**
116-
* mlxbf_tmfifo_vdev - Structure of the TmFifo virtual device
116+
* struct mlxbf_tmfifo_vdev - Structure of the TmFifo virtual device
117117
* @vdev: virtio device, in which the vdev.id.device field has the
118118
* VIRTIO_ID_xxx id to distinguish the virtual device.
119119
* @status: status of the device
120120
* @features: supported features of the device
121121
* @vrings: array of tmfifo vrings of this device
122+
* @config: non-anonymous union for cons and net
122123
* @config.cons: virtual console config -
123124
* select if vdev.id.device is VIRTIO_ID_CONSOLE
124125
* @config.net: virtual network config -
@@ -138,7 +139,7 @@ struct mlxbf_tmfifo_vdev {
138139
};
139140

140141
/**
141-
* mlxbf_tmfifo_irq_info - Structure of the interrupt information
142+
* struct mlxbf_tmfifo_irq_info - Structure of the interrupt information
142143
* @fifo: pointer to the tmfifo structure
143144
* @irq: interrupt number
144145
* @index: index into the interrupt array
@@ -150,7 +151,7 @@ struct mlxbf_tmfifo_irq_info {
150151
};
151152

152153
/**
153-
* mlxbf_tmfifo_io - Structure of the TmFifo IO resource (for both rx & tx)
154+
* struct mlxbf_tmfifo_io - Structure of the TmFifo IO resource (for both rx & tx)
154155
* @ctl: control register offset (TMFIFO_RX_CTL / TMFIFO_TX_CTL)
155156
* @sts: status register offset (TMFIFO_RX_STS / TMFIFO_TX_STS)
156157
* @data: data register offset (TMFIFO_RX_DATA / TMFIFO_TX_DATA)
@@ -162,7 +163,7 @@ struct mlxbf_tmfifo_io {
162163
};
163164

164165
/**
165-
* mlxbf_tmfifo - Structure of the TmFifo
166+
* struct mlxbf_tmfifo - Structure of the TmFifo
166167
* @vdev: array of the virtual devices running over the TmFifo
167168
* @lock: lock to protect the TmFifo access
168169
* @res0: mapped resource block 0
@@ -198,7 +199,7 @@ struct mlxbf_tmfifo {
198199
};
199200

200201
/**
201-
* mlxbf_tmfifo_msg_hdr - Structure of the TmFifo message header
202+
* struct mlxbf_tmfifo_msg_hdr - Structure of the TmFifo message header
202203
* @type: message type
203204
* @len: payload length in network byte order. Messages sent into the FIFO
204205
* will be read by the other side as data stream in the same byte order.
@@ -208,6 +209,7 @@ struct mlxbf_tmfifo {
208209
struct mlxbf_tmfifo_msg_hdr {
209210
u8 type;
210211
__be16 len;
212+
/* private: */
211213
u8 unused[5];
212214
} __packed __aligned(sizeof(u64));
213215

0 commit comments

Comments
 (0)