Skip to content

Commit cc346a4

Browse files
awilliambjorn-helgaas
authored andcommitted
PCI: Add function 1 DMA alias quirk for Marvell devices
Several Marvell devices and a JMicron device have a similar DMA requester ID problem to Ricoh, except they use function 1 as the PCIe requester ID. Add a quirk for these to populate the DMA alias with the correct devfn. Link: https://bugzilla.kernel.org/show_bug.cgi?id=42679 Tested-by: George Spelvin <[email protected]> Tested-by: Andreas Schrägle <[email protected]> Tested-by: Tobias N <[email protected]> Tested-by: <[email protected]> Signed-off-by: Alex Williamson <[email protected]> Signed-off-by: Bjorn Helgaas <[email protected]>
1 parent ec637fb commit cc346a4

File tree

1 file changed

+36
-0
lines changed

1 file changed

+36
-0
lines changed

drivers/pci/quirks.c

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3349,6 +3349,42 @@ static void quirk_dma_func0_alias(struct pci_dev *dev)
33493349
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_RICOH, 0xe832, quirk_dma_func0_alias);
33503350
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_RICOH, 0xe476, quirk_dma_func0_alias);
33513351

3352+
static void quirk_dma_func1_alias(struct pci_dev *dev)
3353+
{
3354+
if (PCI_FUNC(dev->devfn) != 1) {
3355+
dev->dma_alias_devfn = PCI_DEVFN(PCI_SLOT(dev->devfn), 1);
3356+
dev->dev_flags |= PCI_DEV_FLAGS_DMA_ALIAS_DEVFN;
3357+
}
3358+
}
3359+
3360+
/*
3361+
* Marvell 88SE9123 uses function 1 as the requester ID for DMA. In some
3362+
* SKUs function 1 is present and is a legacy IDE controller, in other
3363+
* SKUs this function is not present, making this a ghost requester.
3364+
* https://bugzilla.kernel.org/show_bug.cgi?id=42679
3365+
*/
3366+
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_MARVELL_EXT, 0x9123,
3367+
quirk_dma_func1_alias);
3368+
/* https://bugzilla.kernel.org/show_bug.cgi?id=42679#c14 */
3369+
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_MARVELL_EXT, 0x9130,
3370+
quirk_dma_func1_alias);
3371+
/* https://bugzilla.kernel.org/show_bug.cgi?id=42679#c47 + c57 */
3372+
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_MARVELL_EXT, 0x9172,
3373+
quirk_dma_func1_alias);
3374+
/* https://bugzilla.kernel.org/show_bug.cgi?id=42679#c59 */
3375+
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_MARVELL_EXT, 0x917a,
3376+
quirk_dma_func1_alias);
3377+
/* https://bugzilla.kernel.org/show_bug.cgi?id=42679#c46 */
3378+
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_MARVELL_EXT, 0x91a0,
3379+
quirk_dma_func1_alias);
3380+
/* https://bugzilla.kernel.org/show_bug.cgi?id=42679#c49 */
3381+
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_MARVELL_EXT, 0x9230,
3382+
quirk_dma_func1_alias);
3383+
/* https://bugs.gentoo.org/show_bug.cgi?id=497630 */
3384+
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_JMICRON,
3385+
PCI_DEVICE_ID_JMICRON_JMB388_ESD,
3386+
quirk_dma_func1_alias);
3387+
33523388
static struct pci_dev *pci_func_0_dma_source(struct pci_dev *dev)
33533389
{
33543390
if (!PCI_FUNC(dev->devfn))

0 commit comments

Comments
 (0)