USB: mos7840: remove unnecessary null test before kfree

Fabian Frederick · jhovold · commit cca16d624266 · 2014-07-07T10:19:29.000+02:00
Cc: Johan Hovold &lt;jhovold@gmail.com&gt;
Cc: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
Cc: linux-usb@vger.kernel.org
Signed-off-by: Fabian Frederick &lt;fabf@skynet.be&gt;
Signed-off-by: Johan Hovold &lt;johan@kernel.org&gt;
diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
@@ -1181,10 +1181,7 @@ static void mos7840_close(struct usb_serial_port *port)
 	/* Freeing Write URBs */
 	for (j = 0; j < NUM_URBS; ++j) {
 		if (mos7840_port->write_urb_pool[j]) {
-			if (mos7840_port->write_urb_pool[j]->transfer_buffer)
-				kfree(mos7840_port->write_urb_pool[j]->
-				      transfer_buffer);
-
+			kfree(mos7840_port->write_urb_pool[j]->transfer_buffer);
 			usb_free_urb(mos7840_port->write_urb_pool[j]);
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -1181,10 +1181,7 @@ static void mos7840_close(struct usb_serial_port *port)`
`1181`	`1181`	`/* Freeing Write URBs */`
`1182`	`1182`	`for (j = 0; j < NUM_URBS; ++j) {`
`1183`	`1183`	`if (mos7840_port->write_urb_pool[j]) {`
`1184`		`- if (mos7840_port->write_urb_pool[j]->transfer_buffer)`
`1185`		`- kfree(mos7840_port->write_urb_pool[j]->`
`1186`		`- transfer_buffer);`
`1187`		`-`
	`1184`	`+ kfree(mos7840_port->write_urb_pool[j]->transfer_buffer);`
`1188`	`1185`	`usb_free_urb(mos7840_port->write_urb_pool[j]);`
`1189`	`1186`	`}`
`1190`	`1187`	`}`