Skip to content

Commit cdeb5c0

Browse files
Sergei ShtylyovVinod Koul
authored andcommitted
rcar-hpbdma: remove shdma_free_irq() calls
Commit c1c63a1 (DMA: shdma: switch to managed resource allocation) got rid of shdma_free_irq() but unfortunately got merged later than commit c4f6c41 (dma: add driver for R-Car HPB-DMAC), so that the HPB-DMAC driver retained the calls and got broken: drivers/dma/sh/rcar-hpbdma.c: In function `hpb_dmae_alloc_chan_resources': drivers/dma/sh/rcar-hpbdma.c:435: error: implicit declaration of function `shdma_free_irq' Fix this compilation error by removing the remaining shdma_free_irq() calls. Reported-by: Simon Horman <[email protected]> Signed-off-by: Sergei Shtylyov <[email protected]> Tested-by: Simon Horman <[email protected]> Signed-off-by: Vinod Koul <[email protected]>
1 parent d0e639c commit cdeb5c0

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

drivers/dma/sh/rcar-hpbdma.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -432,7 +432,6 @@ hpb_dmae_alloc_chan_resources(struct hpb_dmae_chan *hpb_chan,
432432
hpb_chan->xfer_mode = XFER_DOUBLE;
433433
} else {
434434
dev_err(hpb_chan->shdma_chan.dev, "DCR setting error");
435-
shdma_free_irq(&hpb_chan->shdma_chan);
436435
return -EINVAL;
437436
}
438437

@@ -614,7 +613,6 @@ static void hpb_dmae_chan_remove(struct hpb_dmae_device *hpbdev)
614613
shdma_for_each_chan(schan, &hpbdev->shdma_dev, i) {
615614
BUG_ON(!schan);
616615

617-
shdma_free_irq(schan);
618616
shdma_chan_remove(schan);
619617
}
620618
dma_dev->chancnt = 0;

0 commit comments

Comments
 (0)