Skip to content

Commit ceabee6

Browse files
YueHaibingdavem330
authored andcommitted
genetlink: Fix a memory leak on error path
In genl_register_family(), when idr_alloc() fails, we forget to free the memory we possibly allocate for family->attrbuf. Reported-by: Hulk Robot <[email protected]> Fixes: 2ae0f17 ("genetlink: use idr to track families") Signed-off-by: YueHaibing <[email protected]> Reviewed-by: Kirill Tkhai <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 33872d7 commit ceabee6

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

net/netlink/genetlink.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -366,7 +366,7 @@ int genl_register_family(struct genl_family *family)
366366
start, end + 1, GFP_KERNEL);
367367
if (family->id < 0) {
368368
err = family->id;
369-
goto errout_locked;
369+
goto errout_free;
370370
}
371371

372372
err = genl_validate_assign_mc_groups(family);
@@ -385,6 +385,7 @@ int genl_register_family(struct genl_family *family)
385385

386386
errout_remove:
387387
idr_remove(&genl_fam_idr, family->id);
388+
errout_free:
388389
kfree(family->attrbuf);
389390
errout_locked:
390391
genl_unlock_all();

0 commit comments

Comments
 (0)